I've been unable to get the 6.x-1.x-dev version to send any messages, so I set about tracking down the problem. It turns out that simplenews_digest_set_next_times() never gets called, therefore the variable simplenews_digest_end_time never gets set. Therefore simplenews_digest_cron never does anything.

The fix is simple, just a variable that was mis-named.

Broken simplenews_digest_form_alter():

// This function is needed to insert our own form handler for digest settings page.
function simplenews_digest_form_alter(&$form, &$form_state, $form_id) {
  if($form_id == 'simplenews_digest_settings') {
    $form_data['#submit'][] = 'simplenews_digest_settings_handler_submit';
  }
}

Fixed simplenews_digest_form_alter():

// This function is needed to insert our own form handler for digest settings page.
function simplenews_digest_form_alter(&$form, &$form_state, $form_id) {
  if($form_id == 'simplenews_digest_settings') {
    $form['#submit'][] = 'simplenews_digest_settings_handler_submit';
  }
}

Comments

Morris Singer’s picture

Status: Active » Fixed

I have fixed the module per specification and committed the change in the most recent development snapshot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.