Simplenews Digest does not initialize properly (includes fix)

anthrocreative - July 10, 2009 - 01:25
Project:Simplenews Digest
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I've been unable to get the 6.x-1.x-dev version to send any messages, so I set about tracking down the problem. It turns out that simplenews_digest_set_next_times() never gets called, therefore the variable simplenews_digest_end_time never gets set. Therefore simplenews_digest_cron never does anything.

The fix is simple, just a variable that was mis-named.

Broken simplenews_digest_form_alter():

// This function is needed to insert our own form handler for digest settings page.
function simplenews_digest_form_alter(&$form, &$form_state, $form_id) {
  if($form_id == 'simplenews_digest_settings') {
    $form_data['#submit'][] = 'simplenews_digest_settings_handler_submit';
  }
}

Fixed simplenews_digest_form_alter():

// This function is needed to insert our own form handler for digest settings page.
function simplenews_digest_form_alter(&$form, &$form_state, $form_id) {
  if($form_id == 'simplenews_digest_settings') {
    $form['#submit'][] = 'simplenews_digest_settings_handler_submit';
  }
}

#1

Morris Singer - July 23, 2009 - 14:29
Status:active» fixed

I have fixed the module per specification and committed the change in the most recent development snapshot.

#2

System Message - August 6, 2009 - 14:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.