String issues
| Project: | User Relationships |
| Version: | 6.x-1.0-rc1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | alex.k |
| Status: | closed |
Jump to:
There are some string issues in the module (sorry for not being able to specify the exact module but I extracted all strings into one po file for the first translation pass).
'After saving and existing relationship type' ('and' instead of 'an')
There is a string 'Unable to find relationship types: @types' with plural and singular string, both are the same (singular is wrong).
In my eyes 'This will show relationships next to the user name on My relationships pages.' should be somthing like 'This will show pictures of relationships next to the user name on My relationships pages.' (there is no hint on photos in the original string so far).
On page ?q=admin/user/relationships/settings there are some group headers such as 'Request' or 'Informational' that cannot be translated. It looks like some options are untranslatable too, please go through all of them.
Thanks for the great module anyway!
#1
Agreed on all points. Fixed and committed in http://drupal.org/cvs?commit=235626. Please give it a try. Thanks!
#2
Thanks, I will have a look on it.
In the meantime there is another string to be reviewed: In 'Whether or not the relationship is one way or mutual', the 'or not' doesn't fit - a relationship can only be mutual or one way, there is no room for an 'or not', isn't it.
#3
OK, I went through the corrections now. There is an error in a corrected string: 'This will show user's picture picture next to the user name on My relationships pages.' contains a duplicate 'picture'.
On page ?q=admin/user/relationships/settings I still can't translate 'Request' and 'Pre-approved' in the Email settings.
On the same page under the notifications I still can't translate the group header 'informational' and most of the entries that are following such as 'Submitted', 'Accepted', etc., it's the same with the entries under 'Errors' (the header itself IS correctly translatable) such as 'Too many relationships', 'Existing Request', etc..
The other things mentioned when opening the issue are correctly fixed, thanks!
#4
In my eyes in 'Allow users to elaborate on their relationships others' there should be a 'to' before 'others'!?
#5
Corrected these issues, committed in http://drupal.org/cvs?commit=236380. My first attempt at making the admin form translatable didn't work, I guess it just had to be done properly :)
#6
Should have been marked fixed earlier.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.