Error messages should be padded

Dane Powell - July 12, 2009 - 01:33
Project:Pixture Reloaded
Version:6.x-3.2
Component:Code
Category:bug report
Priority:normal
Assigned:Jeff Burnz
Status:needs review
Description

In Drupal error messages (div.error class), the text overlays the background "stop" image, making it unreadable. I think the text should be padded on the left like other Drupal messages are (like div.messages).

#1

Jeff Burnz - July 12, 2009 - 02:23
Assigned to:Anonymous» Jeff Burnz

Yes, I really must release another version with all these fiddly bits fixed up, thanks, I know about it but time is so precious right now - patches anyone?

#2

Dane Powell - July 12, 2009 - 03:30

I tried to just add the necessary padding to the class definition in style.css, but it seems to be getting stripped out, I guess by the Color module. I don't know why or how to fix it.

#3

ScoutBaker - July 18, 2009 - 04:45

After changing the .css file, you have to go to the theme settings page and save the settings. You don't have to change anything, just save the settings again. That regenerates the color files and updates the the .css for your color scheme.

#4

Dane Powell - July 18, 2009 - 13:54

Ah, okay. I was just flushing the caches and expecting the CSS to be regenerated. Thanks for the tip.

Here's a dead-simple patch for you.

AttachmentSize
pixture_reloaded-516698.patch 332 bytes

#5

Dane Powell - July 18, 2009 - 13:55
Status:active» needs review

#6

Jeff Burnz - July 19, 2009 - 18:11

Thanks, I'll commit to head in couple of days when I am home from holiday.

#7

Dane Powell - November 9, 2009 - 23:17

It doesn't look like this has made it into head yet, has it? Just trying to close out some of my old issues here.

 
 

Drupal is a registered trademark of Dries Buytaert.