In Drupal error messages (div.error class), the text overlays the background "stop" image, making it unreadable. I think the text should be padded on the left like other Drupal messages are (like div.messages).

CommentFileSizeAuthor
#4 pixture_reloaded-516698.patch332 bytesdanepowell

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: Unassigned » Jeff Burnz

Yes, I really must release another version with all these fiddly bits fixed up, thanks, I know about it but time is so precious right now - patches anyone?

danepowell’s picture

danepowell commented

I tried to just add the necessary padding to the class definition in style.css, but it seems to be getting stripped out, I guess by the Color module. I don't know why or how to fix it.

scoutbaker’s picture

scoutbaker commented

After changing the .css file, you have to go to the theme settings page and save the settings. You don't have to change anything, just save the settings again. That regenerates the color files and updates the the .css for your color scheme.

danepowell’s picture

danepowell commented
StatusFileSize
new pixture_reloaded-516698.patch332 bytes

Ah, okay. I was just flushing the caches and expecting the CSS to be regenerated. Thanks for the tip.

Here's a dead-simple patch for you.

danepowell’s picture

danepowell commented
Status: Active » Needs review
Jeff Burnz’s picture

Jeff Burnz commented

Thanks, I'll commit to head in couple of days when I am home from holiday.

danepowell’s picture

danepowell commented

It doesn't look like this has made it into head yet, has it? Just trying to close out some of my old issues here.

tmax’s picture

tmax commented
Title: Error messages should be padded » Customization not hapenning
Assigned: Jeff Burnz » tmax
Priority: Normal » Critical

I installed the theme properly but the customization for the different color sets via the color picker wont work. The theme just dosent set in. Only the default colour scheme works? What could be the problem and how can i correct this?

danepowell’s picture

danepowell commented
Title: Customization not hapenning » Error messages should be padded
Priority: Critical » Normal

Hi Talisuneo

Please don't change the issue title when posting a reply unless you are clarifying the original issue. Also, don't mark an issue as critical unless it is seriously crippling the functionality of a module. In this case, there's no way that my patch could have broken anything unless you applied it wrong.

I would suggest flushing all Drupal caches, go to the Pixture reloaded settings, save them (even if you don't make any changes - this recopies the necessary theme files as mentioned in #3), reflush Drupal caches, and then clear your browser cache and reload the page.

Edit: it sounds like your issue is wholly unrelated to this one- if that's the case, you should create a new issue using the link at the top of the project issue queue.

Jeff Burnz’s picture

Jeff Burnz commented

@talisuneo - HELLO? Start a separate issue thanks very much, don't hijack this one for your own purpose!

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: tmax » Jeff Burnz

Forgot to set the assignment...

tmax’s picture

tmax commented

Hello dane

Thank you so much. Its working fine now. I thought it had something to do with my database.
I needed to flush drupal cache and my browser cache too and its loading fine now.

And i apologize for posting my issue here. I am a complete newbie and this is my first post. Sorry for the critical issue mark too. I am deeply sorry guys. sorry Jeff

Thank you Dane again
cheers

danepowell’s picture

danepowell commented
Status: Needs review » Reviewed & tested by the community
danepowell’s picture

danepowell commented

Anything stopping this from being committed?

mykola kovbasa’s picture

mykola kovbasa commented

#4 - Thanks for patch, it hepls me!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I have marked #683350: Background image is used when not necessary as duplicate of this report.

Jeff Burnz’s picture

Jeff Burnz commented

OK, I am hearing you guys! I'll get onto these issues, soon, right now I'm pretty slammed with D7 but I understand that I really really need to roll a new version of PR as there quite a number of issues that need to be cleaned up.

Encarte’s picture

Encarte commented

subscribing

mcarrera’s picture

mcarrera commented

subscribing

Jeff Burnz’s picture

Jeff Burnz commented
Status: Reviewed & tested by the community » Fixed

this will be fixed in 6.x-4.0

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.