View 2 integration

this looks good over all some of the comments need to be proper sentences with capital letter and periods though. i think the view should probably be tagged with the module name.

though it brings up a bigger problem with the module, it's using ***CURRENT_LANGUAGE*** as a field name. the problem being that language codes conflict with database reserved works. i'm sure using Icelandic you'll get a column named "is". i won't let fixing that block the views support but it just reminded me of it.

Has this patch been implemented in the dev release? I'm getting error messages on a multilingual site on a page using a view with a node reference argument. The multilingual options on the node reference argument are turned on. When they are turned off, the error messages disappear, but translations of referenced content are no longer taken in to account.

The error message is as follows

user warning: Unknown column 'n.nid' in 'on clause' query: SELECT node2.nid, node2.vid, node2.title FROM node node INNER JOIN node node2 on node2.tnid = node.tnid INNER JOIN active_translation ON n.nid = active_translation.en WHERE 1 = 1 AND ( node.nid IN (145) AND node.tnid > 0 ) in /Applications/MAMP/htdocs/vem/sites/all/modules/contrib/nodereferrer/views/nodereferrer.views.inc on line 99.

Fantastic, patch worked a treat for me. Thanks very much.

It took me a while to workout why I could not create an admin view listing all nodes regardless of language.
Started working on my own fix using a views filter until I saw this patch.
Works for me, Thanks.

There is a problem with relationship handler. It needs to use db_escape_table() on the current language. I run into this problem with the language Chinese. The table column is zhhans and the language code is zh-hans.

I have updated the relationship to use a handler. For some reason WinMerge is giving me errors and I don’t have my Suse machine with me so, sorry I cant give you a patch, but here is the code.

Please note that my views coding experience is limited.

active_translation.views.inc

// $Id$

/**
 * @file
 *  views 2 integration of active translation
 */
function active_translation_views_data() {
  $data['active_translation']['table']['group'] = t('i18n');

  // all done by adding the table as a relationship
  // could be offered as a base table as well?
  return $data;
}

/**
 * Implementation of hook_views_data_alter().
 *
 * Need relationship to node table, probably this as an inner join is
 * most common.
 */
function active_translation_views_data_alter(&$data) {
  // issue, can we make the join on a different column with a hook?
  $data['node']['active_translation'] = array(
    'group' => t('i18n'),
    'title' => t('Active translation'),
    'help' => t('Relate node table to active translations.'),
    'relationship' => array(
      'relationship table' => 'node',
      'relationship field' => 'nid',
      'base' => 'active_translation',
      'base field' => '***CURRENT_LANGUAGE***',
      'handler' => 'active_translation_relationship_handler',
      'label' => t('Active translation'),
    ),
  );
}

/**
 * Implementation of hook_views_handlers
 */
function active_translation_views_handlers() {
  return array(
    'info' => array(
      'path' => drupal_get_path('module', 'active_translation') . '/views',
    ),
    'handlers' => array(
      'active_translation_relationship_handler' => array(
        'parent' => 'views_handler_relationship',
      ),
    ),
  );
}

active_translation_relationship_handler.inc

class active_translation_relationship_handler extends views_handler_relationship {

  function query() {
    global $language;
    $field = db_escape_table($language->language);
    $this->ensure_my_table();
    $join = new views_join();
    $join->construct('active_translation', $this->table_alias, 'nid', $field, array(), 'INNER');
    $this->query->ensure_table('active_translation', $this->relationship, $join);
  }

}

subscribing

I'm looking for an alternate to http://drupal.org/project/select_translation as it looks to not be maintained.
I hope this feature request can incorporate Views 3 support.

Thanks!

the mention of using db_escape_table() on the field names reminds me about #791172: Active translation with Tongan causes SQL errors. Wonder if fixing that there would make the views support easier to add...

@ekes
I would say yes, see comment #8.