I just fixed the preprocess function for the theme call, where suggestions where placed into 'suggestions' array-key, but Drupal6 wants it in the 'template_files' key.

Also I replaced the left/right guillemets with their proper HTML-entities.
Patch below

CommentFileSizeAuthor
#3 custom_pagers-517016-2.patch1.6 KBplach
#2 custom_pagers.module-517016-1.patch1.66 KBplach
#1 custom_pagers.module-517016-1.patch1.66 KBdarren oh
custom_pagers-6--1-10-BETA1.patch1.62 KBjapanitrat

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
StatusFileSize
new custom_pagers.module-517016-1.patch1.66 KB

Function also needs to be renamed because it is the default preprocessor.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new custom_pagers.module-517016-1.patch1.66 KB 
+++ custom_pagers.module	(working copy)
@@ -301,19 +301,19 @@
+function template_preprocess_custom_pager(&$vars) {

Is the current value a new best practice for this? Also CCK is currently following the moduleName_preprocess_hook pattern but about the template_preprocess_hook pattern the theming guide says: "The module or core file that implements the theming hook supplies this."

+++ custom_pagers.module	(working copy)
@@ -301,19 +301,19 @@
+  $vars['previous'] = !empty($nav['prev']) ? l(t('‹ previous'), 'node/'. $nav['prev']) : '';
   $vars['key'] = t('@count of @count_total', array('@count' => ($nav['current_index'] + 1), '@count_total' => count($nav['full_list'])));
-  $vars['next'] =  !empty($nav['next']) ? l(t('next ›'), 'node/'. $nav['next']) : '';
+  $vars['next'] =  !empty($nav['next']) ? l(t('next ›'), 'node/'. $nav['next']) : '';

The HTML entities are escaped by l(), we need to pass it a 'html' => TRUE here. I'd leave this bit of code alone.
Rerolled the patch without it.

Aside from these RTBC.

Powered by Dreditor.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new custom_pagers-517016-2.patch1.6 KB

oops, wrong patch

eaton’s picture

eaton commented
Status: Needs review » Fixed

Patch applied, thanks for the fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.