Similar to (perhaps could be rolled with) #266099: Allow to configure margin-top setting per theme

Started a separate issue so as not to confuse matters. Basically, some themes (e.g. the excellent RootCandy: http://drupal.org/project/rootcandy) have CSS/JavaScript bits competing with admin_menu. I don't want to switch admin_menu off, but it would be useful to switch it off while a specific theme is being viewed, so I can make use of the features of that theme without them obscuring or being obscured by the admin menu.

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

RootCandy has built-in support for admin_menu. How to enable that should be explained in the README.txt, perhaps in the latest dev snapshot only.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Hmm, there doesn't seem to be a readme in the dev snapshot and the latest stable version doesn't have any admin_menu options. Just the option to switch off RootCandy's sliding panel (which I have done). Oh well. If RootCandy has it covered I will hang tight for a release with that feature. Thanks! =)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

See http://drupal.org/project/issues/admin_menu?text=rootcandy&status=All&pr...

resp. #373814: Implement the rootcandy theme

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Closed (won't fix) » Active

Oh, I see. That is the feature in RootCandy I've already seen (and use).

I wouldn't call it support. It just offers an option to switch off the feature of RootCandy that conflicts with admin_menu. My use case is I want to *keep* the feature of RootCandy but switch off admin_menu, only for RootCandy. At present I can't do this.

My feature request is for admin_menu to reciprocate the feature in RootCandy. Though RootCandy is the only theme I know of that currently gets in the way of admin_menu, there are sure to be others, so the ability to say "don't show admin_menu on theme X" would be a useful general feature, IMHO.

Set back to active, but if (after clarification) you still think it's a "won't fix" then I won't push it any further... =)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

well... I can see your point, but the real issue is that just hiding admin_menu in a theme is rather wrong. You would/should disable the module instead, so you avoid the extra cycles for admin_menu to be built, processed, and displayed.

That said, I think that no theme should provide a menu or header bar like admin_menu, because that is module functionality, not theme functionality.

The only real option I see here is to tweak RootCandy, so it automatically hides it own bar, and applies a different look to admin_menu, so it looks similar to its own bar.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (works as designed)

For above reasons, I'm marking this issue as by design. Feel free to re-open and move it to the RootCandy project though.

pyrello’s picture

pyrello commented
Status: Closed (works as designed) » Active

Hello,

I would like to re-open this feature request. I am an admin menu junkie (I have a lot of trouble without it). My use case is that I have a site that uses mobile themes on certain devices. When I have admin menu enabled when I log in from my phone, it completely dominates the screen and makes it hard to do anything. Right now, I either have to not log in from my phone to have admin menu enabled, or disable admin menu.

I think it should be the purview of this module rather than the individual themes to disable the admin menu per theme.

Thanks!

Sean

Helmut Neubauer’s picture

Helmut Neubauer commented

Subscribe: I agree with pyrello

wxman’s picture

wxman commented

I was just looking for the same solution as pyrello.

It's not an answer, but I added this to a function in my template.php for the mobile theme

if (db_is_active()) {
  $filestring = url($_GET['q']);
  $pos = strpos($filestring, '/admin/');
  if ($pos === false) {
    module_invoke('admin_menu', 'suppress');
  }
  include_once(drupal_get_path('theme', 'adaptivetheme') .'/inc/template.custom-functions.inc');
}

The "if (db_is_active())" was already there to invoke the include_once. I just added the rest. this makes it so the admin menu only shows when I'm in an admin section. Like I said, it's not an answer, but it helps the design process.

pyrello’s picture

pyrello commented

I think it is worth noting that I gave up on admin menu a while back exactly because of this issue and moved over to admin.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

A theme setting is the wrong answer to the question.

See you over in #1419044: Responsive strategy for admin_menu