Hi James,

It's great to see this module improving -- I like the new feature of making the author contact form collapsible!

However, it seems the email validation isn't being executed in the latest dev version 6.x-1.x-dev.

On line 54:

    $form['authorcontact']['sendername'] = array(
        '#title' => t('Your name'),
        '#type' => 'textfield',
        '#required' => true,
		'#element_validate' => array('authorcontact_form_validate')
    );

I think
'#element_validate' => array('authorcontact_form_validate')
should be under senderemail in stead of sendername? I tried putting it there, but the validation still isn't executed...

Also, the email I receive looks like this (I substituted my site with example.com):

-----Title------
Contact from !site

-----Content------
You have recieved an enquiry through example.com on the page at http://example.com/testing/page

Name:
Email:

Enquiry:
-----------

I seems the variables are getting lost somewhere along the way 8o)

Comments

JmsCrk’s picture

JmsCrk commented
Status: Active » Fixed

Thanks for that pickup ressa - and eek! I had reverted to an old version, it's all sorted out now, 6.x dev is tested and working properly. It send correctly, values filled in, and VALIDATES as it should!

Thanks for your help and your prompt tests of the dev version.

ressa’s picture

ressa
he/him
commented

Great, thanks for the quick response!

You probably haven't had time to upload the fixed 6.x dev yet, or maybe the drupal.org needs to run "Module cron" or something to pick it up? In any case the online version is still the old 6.x-1.x-dev.

JmsCrk’s picture

JmsCrk commented

It is uploaded, the packaging script just needs to pick it up and redo the dev tarball, i'm not sure how long that takes but I think it's every few hours.

Meanwhile you can access it at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/authorconta... (ignore the d6 folder)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.