Right now if you go on user edit page (when there are more than 2 themes enabled) you see a form to select which theme you prefer to use. Even if the default site's theme has the string "(site default theme)" append to it, nothing let you to believe that if you choose that theme your user theme will change every time the site default theme changes.

I consider this a bug and an usability problem. The solution I come up with is to add as first row in the theme selection table a new row which gives the user the explicit option to use the default site theme and in this way he has the option to choose the current site default theme as his/her permanent user theme.

As a side effect this will solve #517068: E_NOTICE thrown by element_children() on user/%uid/edit page too.

CommentFileSizeAuthor
#2 user-theme-configuration.png21.37 KBtic2000
default-theme-is-my-user-theme.patch2.13 KBtic2000

Comments

Bojhan’s picture

Bojhan commented
Issue tags: +Usability, +Needs screenshots

Needs screenshot

tic2000’s picture

tic2000 commented
StatusFileSize
new user-theme-configuration.png21.37 KB

Screenshot attached.
I don't know how to display it inline. Any hint?

tic2000’s picture

tic2000 commented
Issue tags: -Needs screenshots
Bojhan’s picture

Bojhan commented

Can't we just go with Garland (Default)

tic2000’s picture

tic2000 commented

"(site default theme)" is the current text. I didn't touch that. But of course I can change that.
Right now the options available are all but the first. The problem is that if you choose Garland, but the default site themes changes to Stark for example, your theme will be Stark too, it will not remain Garland as I would expected.

Bojhan’s picture

Bojhan commented

Wondering whether we shouldn't just change behavior? Basically by not adding an extra row, but giving the option either the default or something else. And the default always moves with the default of the site.

tic2000’s picture

tic2000 commented

Can you show me? Cause I understand that you want to have it like it is now. Select default theme that will move with the site theme, but I don't understand how can I select the default theme that will not move with the site.

Bojhan’s picture

Bojhan commented

Well, yes - similar to now. I think that the "default theme" doesn't make sense to the user - as he doesn't know what the default them is. But would it make sense to display the current site default as the default, and move that with the user? Like now? - Not sure what we are changing then though :P

tic2000’s picture

tic2000 commented

So I'm the user. I go to my account page and see the available themes. I select Garland cause I like it. Garland happens to be the default site theme too. The site owner decides to change the default theme and I suddenly have the new theme even if I selected Garland so I have to go to select Garland again. Is that good usability?

If the "Default site theme doesn't" make sense we should provide a description. Or change the text to something that makes sense.

Right now if you go to your account page there is no theme selected. If you decide to select one I think it's obvious you want that as your theme and don't want it changed when the site theme changes.

zoen’s picture

zoen commented

The patch works and I agree that the change is a usability improvement.

Here are screen snaps of the "Theme configuration" section of the user-account edit form, showing the change this patch makes:

  • Before: http://skitch.com/zoen/b23r3/zoe-local.d7
    Notice that there is no indication that, when you select the theme marked "site default theme", your theme will change whenever the site default theme is changed. And there is no way to choose the site's current default theme as your theme for keeps.
  • After: http://skitch.com/zoen/b23r7/zoe-local.d7
    Behold, now you can select any theme, including the site's current default theme, to be your theme for as long as you like; or, you can select to always use whatever the site default theme is changed to.

I'd suggest the following as a further improvement: the option "Always use the default site theme" should be selected by default on this form, since that's the default behavior anyway.

Bojhan’s picture

Bojhan commented

Definitly, my argument is that - can people differentiate from the site's default theme(garland) and garland beign diffrent?

tic2000’s picture

tic2000 commented

I think the fact that there is no screenshot for "Always use site theme" can help. Also I think we should drop "default" from one of the text. Maybe just say "Current site theme" or something similar for the theme that is currently the default for the site.

Status: Needs review » Needs work

The last submitted patch failed testing.

zoen’s picture

zoen commented
Status: Needs work » Closed (won't fix)

Configurable themes per user have actually just been removed from drupal 7 core. Therefore, this issue is totally deadalized.

Here's the issue: http://drupal.org/node/292253
And the CVS record: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/system/system.modu...

zoen’s picture

zoen commented
Status: Closed (won't fix) » Closed (fixed)