Hi, thanks for a great module.

I'm the maintainer of Page Title and thought I'd give this a whirl - thanks for getting it Page Title compliant again.

I attach a patch which contains several fixes to code compliance (use of theme_table() rather than theme('table') for instance) and some tweaks to the way tables are displayed. This included adding a new CSS file + some CSS classes to the tables.

This produces a neat green/yellow/red with tick, warning and error symbols (like the status report page) making it MUCH easier to find the rows with errors.

One caveat... the CSS is hardcoded to /misc/error.png, etc.... So if the site is running in a sub-folder it will likely fail to show images. We cannot code a relative path as we dont know where the module will be installed. I'm not sure how to address this... but it's only a minor issue. Row colouring will still work and the site wont die...

Comments

nicholasthompson’s picture

StatusFileSize
new1.46 MB
new388.61 KB

Screenshots...

kristen pol’s picture

You are awesome! Thanks!! I will get this rolled in soon... hopefully today. Very cool.

:)Kristen

kristen pol’s picture

The css file is missing from the patch. I tried getting it from:

http://www.thingy-ma-jig.co.uk/sites/all/modules/seo_friend/seo_friend.a...

but it's not there. Can you please attach?

Thanks!
Kristen

nicholasthompson’s picture

Sorry - forgot... Not sure why the diff didn't pick it up.

http://www.thingy-ma-jig.co.uk/sites/thingy-ma-jig.co.uk/modules/seo_fri...

kristen pol’s picture

Status: Needs review » Closed (fixed)

Thanks Nicholas! It's rolled into beta3.

:)Kristen