Hi, thanks for a great module.
I'm the maintainer of Page Title and thought I'd give this a whirl - thanks for getting it Page Title compliant again.
I attach a patch which contains several fixes to code compliance (use of theme_table() rather than theme('table') for instance) and some tweaks to the way tables are displayed. This included adding a new CSS file + some CSS classes to the tables.
This produces a neat green/yellow/red with tick, warning and error symbols (like the status report page) making it MUCH easier to find the rows with errors.
One caveat... the CSS is hardcoded to /misc/error.png, etc.... So if the site is running in a sub-folder it will likely fail to show images. We cannot code a relative path as we dont know where the module will be installed. I'm not sure how to address this... but it's only a minor issue. Row colouring will still work and the site wont die...
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | SEO Reports - main.png | 388.61 KB | nicholasthompson |
| #1 | SEO Reports-page-title.png | 1.46 MB | nicholasthompson |
| seo_friend.patch | 10.15 KB | nicholasthompson |
Comments
Comment #1
nicholasthompsonScreenshots...
Comment #2
kristen polYou are awesome! Thanks!! I will get this rolled in soon... hopefully today. Very cool.
:)Kristen
Comment #3
kristen polThe css file is missing from the patch. I tried getting it from:
http://www.thingy-ma-jig.co.uk/sites/all/modules/seo_friend/seo_friend.a...
but it's not there. Can you please attach?
Thanks!
Kristen
Comment #4
nicholasthompsonSorry - forgot... Not sure why the diff didn't pick it up.
http://www.thingy-ma-jig.co.uk/sites/thingy-ma-jig.co.uk/modules/seo_fri...
Comment #5
kristen polThanks Nicholas! It's rolled into beta3.
:)Kristen