The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Upgraded to Panels beta 4 today and it seems to have jacked up a bunch 'o things with Total Control.
* The main dashboard gives a page not found error and shows the Tasks tab instead.
* All of the tabs now show up in the Admin Menu at the top of the screen.
* Dashboard link no longer showing up on some user navigation blocks (tho that may be some other issue)
Reverting back to Panels beta 2 to see if that restores everything.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | total_control_og_default_dev.patch | 468 bytes | populist |
| #17 | total_control.tgz | 0 bytes | jenlampton |
| #16 | total_contro_rc1_and_more.patch | 18.69 KB | populist |
| #10 | total_control_refactor_dashboard.patch | 13.95 KB | populist |
| #2 | total_control_panelsb4.patch | 2.39 KB | populist |
Comments
Comment #1
FunkMonkey commentedLooks like the Delegator module has been replaced by a Page Manager module. Turning that on fixed the Admin Menu problem and there is no longer a page not found error on /admin/dashboard. However, now all of the tabs are gone except Summary and Edit Panel. Wow.. took a look and all of the Total Control views are gone.
Weird.. Total Control module is now disabled in Modules.. and grayed out. Because of missing Delegator module? guess that's the hard part about developing on beta modules, eh.
Have fun Jen!
Comment #2
populist commentedHere is a patch that for Panels Beta 4!
Comment #3
FunkMonkey commentedWhoot! Thanks populist. That did the trick. Everything seems back to normal. I really need to learn more about how all of the module code etc works. I don't think I'd be able to figure that out.. except changing from delegator to page manager.
Comment #4
populist commentedThats great. I installed it on two sites and it seems good. Marking for Review.
Comment #5
pobster commentedThere's a problem with the patch at #2;
page_manager_page_savedoes not exist as a function in the main module file so needs an include before you can call it.Pobster
Comment #6
populist commentedDid you enable Page Manager module to begin with? When you update Panels to Beta 4 you need to enable Page Manager to get the magic working.
Comment #7
pobster commentedRead my post again; The function you're calling is in ctools/page_manager/plugins/tasks/page.inc not in the main module file. The only reason you're not getting an error is that you've no need to reinstall the panel as you've already got it installed. Page Manager seems to call this internally but meh, seems to work with a simple include_once call.
Pobster
Comment #8
merlinofchaos commentedChanging title to something more friendly.
Comment #9
merlinofchaos commentedInteresting. Reading htis patch, the install actually saves a page to the database. IMO this is the wrong approach; the page should be provided as a default so that it can be more easily updated and maintained in code. I would highly recommend making that change with this patch.
Comment #10
populist commentedThis patch is a refactoring of the default dashboard page handling as per merlin's suggestion in #9. The dashboard page is now being defined as a default task (hook_page_manager_tasks) and extended with a handler (hook_default_page_manager_handlers).
This is a much cleaner approach and cleanly allows us to add in contexts for the dashboard (and additional handlers) which makes for some very interesting possibilities with user context handling (i.e. each $user->role could have optional page customization and individual users could have their own total control pages).
Comment #11
merlinofchaos commentedMinor quibble (very very minor): I've tried to hide teh language for 'task' and 'task handler' from the admin, since those terms have no meaning to users. You can just call it a page or a system page (which users can interpret as system controlled). Otherwise, that's great work, populist!
Comment #12
merlinofchaos commentedWhat is firep()? I tried installing this and I have no such function. I commented it out and things work, but total control spews a lot of notices.
Most of these should be easy fixes.
Comment #13
merlinofchaos commentedThat text needs to be updated. Also under most themes 'Edit Panel' tab should take you directly to the page though thanks to Drupal's tab system it may not show up under themes that do special things with tabs.
Comment #14
populist commentedThe firep() function is the debugging output function for the Drupal For Firebug module left in by mistake.
Comment #15
merlinofchaos commentedJust a poke. Most people dont' get good patch reviews from me. But also, I want to be able to point to this module when I write the official release announcement for the 3.0 release, so getting this in and ready would make me a very happy person.
Comment #16
populist commentedHere is a rerolled patch from #10. This includes changes to support RC1 (language changes pointed out in #13), removing random debug code (firep() error from above), and a first crack at getting rid of the notices generated by non-existent array keys.
Comment #17
jenlamptonIt looks like a bunch of functions/files/directories from the patch in #10 were left out of the patch in #16. I put them all back together and got things working again, on two sites. I'm working on some other fixes too, but would love it if someone else could test this and confirm. I zipped up the whole module since applying these patches didn't go so smoothly, this may make it easier to test.
Comment #18
tobias commentedI am eager to install Total Control on my site but am currently unable.. would be grateful if Total Control could be updated to reflect the changes to Delegator discussed in this thread.
I've tried CTools beta4 but it appears to already have the Page Manager.
Thanks in advance!
Tobias
Comment #19
populist commentedHere is a patch to get Total Control OG working on the -dev branch. The included file name was wrong.
Comment #20
pobster commentedJust to note that you've done the same with the workflow view as well, s/b;
includes/total_control_workflow.default_views.incIn total_control/total_control_workflow.module
Pobster
Comment #21
tallsimon commentedis this the same reason as the /admin/dashboard/users comes up as a 404 error? I was really looking forward to this bit of the module...
Comment #22
pobster commentedYou are using the dev version right? It comes up for me??
Pobster
Comment #23
jenlamptonYou may also need to revisit the views page and "Revert" to the new view to make sure you are using all the versions of views in-code and not an older version that got saved to your db.
Sorry about my delay on getting the 1.0 release out, I want to test the rollout / upgrade process a few more time and make sure the code is good before I release it to the wild. I've committed the patch for og (and a similar change to workflow) to the -dev branch.
Jen
Comment #24
pobster commentedJust to note that there's a few (now deprecated) call-by-reference variables as well, eg.
total_control.module:108 + 111:
total_control_add_views_pane_display(&$view, $content_type, $machine_type);views/control_content.view:843 + 845:
total_control_add_views_pane_display(&$view, $type->name, $machine);The ampersand can be safely removed as the variables are already referenced in the function being called.
Thanks, and loving the work!
Pobster
Comment #25
tobias commentedI am looking forward to exploring the possibilities with this module - it looks terrific! Many thanks for the work.
Cheers,
Tobias
Comment #26
jenlamptonI just tested it on two other sites and it looks to be ok now.
I missed the deprecated call-by-reference in the 1.0 release (next time, please create a new issue! :-) but I've committed the changes to the dev branch.
Jen