I now have a sitemap made of the frontpage and custom links. The frontpage gets priority 1.0 as expected. All the custom links are getting priority 0.5. It seems that I can neither change the general priority for custom links nor for single custom links in the sitemap.
Is this a planned feature?

Good work so far. The rewrite works better than the old module.

Comments

dave reid’s picture

Title: Changing the priority for individual custom links » Individual custom link priority/exclusion
Issue tags: +6.x-2.0-beta blocker

Adding as a beta blocker.

dave reid’s picture

Title: Individual custom link priority/exclusion » Individual custom link priority
Status: Active » Fixed

Doesn't make sense to allow custom inclusion/exclusion for custom links, you can just delete them to exclude. Committed to CVS.

scottrigby’s picture

I thought the issue was about setting priority on custom links? AFAIK there's no option for this currently?

dave reid’s picture

Isn't this what you're referring to? There are priority options for individual custom links.

avpaderno’s picture

It is possible to set the custom links priority, as Dave reported. About being able to enable/disable the custom links, I think it doesn't make sense to have it for the fact that to create a custom link it's enough to insert the relative URL; differently, if the data requested to create a custom links would be more than now, then I would agree that to have the possibility to disable/enable a custom link would be desirable.

scottrigby’s picture

StatusFileSize
new32.16 KB

@Dave Reid: maybe this is another result of my using the Aug-17th build :) Attaching a screenshot of what I've got. The shot you attached looks like exactly what's missing in mine. I assume with latest code I'll be set - thanks :)

@KiamLaLuno: this makes sense to me - I mean, it's nice that core menu items can be disabled (for example) but I definitely don't think that should be mandatory here. I was mainly concerned about setting priority on custom links, which appears to be solved

avpaderno’s picture

Truly, the menu settings page present in Drupal allows to enable/disable the menus that have been defined from third-party modules; in that case, it makes sense to allow to enable/disable them because the data doesn't come from a user.
That is not the case of the custom links handled by XML sitemap.

scottrigby’s picture

@Dave Reid: Yup - latest has the priority option. Thx :)

@KiamLaLuno: ...but users can also create custom menu items, and there is still the ability to disable these custom items too. I see what you mean, however there may be reasons why site users might want to keep a library of disabled items (for periodic or seasonal use, because the site is shared by multiple people and someone may want to propose a change without making it fatal, etc). Not that this is a crucial point... just feedback :)

avpaderno’s picture

In that case, you can use XML sitemap menu, which uses links from a menu. Create a menu that you will use to add links in the sitemap; in that way you will be able to disable them, and they will not be included in the sitemap.

scottrigby’s picture

@KiamLaLuno: we're not able to set XML sitemap menu item priority are we? Just checking.

I guess if anyone cared, enabling/disabling custom xml sitemap links would be a new issue anyway - though I'm personally not concerned about that - just was interested in the idea you mentioned :)

I *would* however be interested in the ability to set 'Change frequency' for custom xml links - which seems doable... (and 'Last updated' woudl be lovely, though I have no idea how we would get the update time).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dave reid’s picture

Status: Closed (fixed) » Fixed

Knew this issue was here somewhere, just had to dig it up again.

@scottrigby: Just added 'Change frequency' options to custom links as well with http://drupal.org/cvs?commit=304328. Thank you for the suggestion and I apologize that it got lost for a while. :/

Status: Fixed » Closed (fixed)
Issue tags: -6.x-2.0-beta blocker

Automatically closed -- issue fixed for 2 weeks with no activity.