Missing t() function for some text
ali.khairat - July 14, 2009 - 12:30
| Project: | Popups: Add and Reference |
| Version: | 6.x-2.0-alpha1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Jump to:
Description
I need to translate add new in the Popups Reference module.
Attached is a patch file
| Attachment | Size |
|---|---|
| diff.patch | 936 bytes |
#1
#2
#3
I was just about to post an identical patch exactly for this. Luckily I saw this post first so I didn't create a duplicate.
But less luckily, seems that this patch has been waiting for months.. Is this going to be added to the next version or what?
These small translation details can get really annoying. I mean this module even uses t() for most UI strings, but these 2 lines
are basically the only important ones (because normal users see them). Imo the admin settings can stay untranslated, if just normal users see the localized version (not the issue here, but imo "normal users" are a priority in UI-related things).
Please fix this.
#4
Thank you for the patch!
This is a so basic thing to fix that it should really be committed.
But I think that the test itself is not really easy to understand for end users:
"Add New: Add Type"
Shouldn't it be:
"Add new Type"?
It's simpler to understand than the original text, don't you think?