While looking into code for a way to check if imagecache preset by a given name exists for my module, I noticed that there is one inconsistent call to imagecache_preset_flush() in imagecache_preset_delete(). Everywhere else imagecache_preset_flush() is called with preset array, but imagecache_preset_delete() calls it with preset id.
There is also a misleading comment on the type of @param in imagecache_preset_flush() that probably is the source of the above bug.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | imagecache_518980.patch | 1.07 KB | drewish |
| #1 | imagecache.flush_calling.patch | 812 bytes | iva2k |
Comments
Comment #1
iva2k commentedAttached patch should fix it.
Please review for committing to 6.x-2.x-dev.
Comment #2
drewish commentedgreat, thanks! added one new line to your patch and committed to DRUPAL-6--2