While looking into code for a way to check if imagecache preset by a given name exists for my module, I noticed that there is one inconsistent call to imagecache_preset_flush() in imagecache_preset_delete(). Everywhere else imagecache_preset_flush() is called with preset array, but imagecache_preset_delete() calls it with preset id.

There is also a misleading comment on the type of @param in imagecache_preset_flush() that probably is the source of the above bug.

Comments

iva2k’s picture

Status: Active » Needs review
StatusFileSize
new812 bytes

Attached patch should fix it.

Please review for committing to 6.x-2.x-dev.

drewish’s picture

Status: Needs review » Fixed
StatusFileSize
new1.07 KB

great, thanks! added one new line to your patch and committed to DRUPAL-6--2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.