Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
forum.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jul 2009 at 19:26 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
michelleIf it's going to be changed, I would sooner see this changed to "replies". Comments are a specific thing in Drupal and, while core does use comments for forum replies, it may not be that way in contrib. Plus, it's keeping more in tune with general forum terminology. I've never heard of any forum software refer to them as comments. They're either "posts" (which generally includes the initial post as well) or "replies" which are all the follow-up posts.
Michelle
Comment #2
EvanDonovan commentedI agree with Michelle. "Comments" would suggest that they were actually Drupal comments, when they might not be stored that way.
"Replies" is much better than "posts", though. Can you re-roll with the word "replies" if you agree & set the issue to "needs review" so the testbot will try your patch?
Comment #3
tgeller commentedDone! Thanks for the guidance.
Comment #4
michelleThanks, tgeller.
I don't have D7 installed so I can't literally test it, but it's just a one word change and looks fine to me on a "read through".
Michelle
Comment #5
amc commentedComment #7
michelle@amc: What is the point in tagging this "forum" when the component is already "forum.module"?
@testing bot: You're on drugs. :P How can changing one word in a string cause failure?
Michelle
Comment #8
john morahan commentedyou need to roll the patch from the drupal root and not from within the modules/forum directory, else the testbot won't know where to apply it
Comment #9
tgeller commentedThanks for the help, John Morahan! One mo' time...
Comment #10
dries commentedCommitted to CVS HEAD. Thanks.
Comment #11
amc commented@Michelle So that people searching by tags and not component can find the issue. Plus it's better than a post that just says "subscribing."