node_feed() generates a dc:creator element for the node author. Aggregator module, however, recognizes only the author element and ignores the dc:creator element.

CommentFileSizeAuthor
#7 519362-dc-creator-D6.patch680 bytesbfroehle
#4 dc-creator.patch907 bytesmfb
#2 dc-creator.patch982 bytesmfb
dc-creator.patch975 bytesmfb

Comments

dries’s picture

dries commented

Good catch!

I'd like to see us use regular if-statements in this case, as well as some additional PHPdoc.

mfb’s picture

mfb
they or he
commented
StatusFileSize
new dc-creator.patch982 bytes

With simpler logic and a comment.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

mfb’s picture

mfb
they or he
commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Needs review
StatusFileSize
new dc-creator.patch907 bytes

Backported to d6.

bfroehle’s picture

bfroehle commented
Status: Needs review » Reviewed & tested by the community

Tested for some feeds which only contain a dc:creator tag and it correctly populates the author.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, dc-creator.patch, failed testing.

bfroehle’s picture

bfroehle commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 519362-dc-creator-D6.patch680 bytes

Uploaded with -D6 at the end so that it doesn't fail the test bot.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed, pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.