Posted by kong on July 15, 2009 at 6:29am
| Project: | Simply Modern Theme |
| Version: | 6.x-1.5 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Hi,
I found that the height of the masthead is not correctly set when enabling the theme for the first time. This is because of the default settings in theme-settings.php:
<?php
'mastheadfixedfluid' => '184px',
?>It should be changed to 184 without 'px' because the 'px' part will be added in page.tpl.php ~line 149
<?php
'mastheadfixedfluid' => '184',
?>And my another concern is the default settings array in theme-settings.php and template.php are not the same. Can't tell if it will create any bugs but according to http://drupal.org/node/177868 it says "Make sure $defaults exactly matches the $defaults in the template.php file."
Thanks for creating this nice and very configurable theme :)
Comments
#1
And a simple patch file to commit
#2