This patch adds a text area to the block configuration page allowing administrators to add some text above their image block.

Please review and post any feedback.

CommentFileSizeAuthor
#4 gmaplocation_blocktext.patch1.38 KBnicholas.alipaz
gmaplocation_blocktext.patch1.6 KBnicholas.alipaz

Comments

nicholas.alipaz’s picture

nicholas.alipaz commented

This is against today's 2.x-dev. I am using the patched version here on my sidebar block:
http://sorkbeachrentals.regencyweb.info/

babbage’s picture

babbage commented
Status: Active » Needs work

Your patch may be against the current 2.x-dev but you've clearly based it on the earlier version, because it reverts some of the changes recently made to the module. (See for instance your re-addition of the line case 'view': default:).

Please re-roll properly against the current 2.x-dev, i.e. this patch should contain only the changes you are actually proposing, and not affect any other code.

babbage’s picture

babbage commented

Also, your patch incorrectly lists the file to be patched against:
+++ gmaplocation_blocktext.module 2009-07-15 13:47:36.000000000 -0700

If you are going to roll your patches against a local file (as opposed to against CVS) you need to manually re-name the source or destination file (whichever one you've named differently) so that it will correctly apply. This patch would be looking for a file called gmaplocation_blocktext.module, which of course does not exist.

Just so you know for future reference. No big deal. :)

nicholas.alipaz’s picture

nicholas.alipaz commented
StatusFileSize
new gmaplocation_blocktext.patch1.38 KB

Ran the patch again. I am pretty sure I had the latest version, but I had copied over some changes (using meld) I did before the latest and in turn overwrote some of the new changes with old code.

This patch should be all good from what I can tell, please test ;)

babbage’s picture

babbage commented
Status: Needs work » Needs review
JaredAM’s picture

JaredAM commented

Works good for me. I was actually on my way to adding this functionality so it's neat to see we're all thinking alike.

nicholas.alipaz’s picture

nicholas.alipaz commented

Thanks, glad to hear you have it working too.

babbage’s picture

babbage commented
Title: Add Text to Block [patch attached] » Add Text to Block
Status: Needs review » Fixed

http://drupal.org/cvs?commit=243088

Note in version committed the css id for this text has been changed from gmaplocation_block_top_text to gmaplocation-block-text-top, so if you had applied this patch previously and styled this text you will need to update your css.

nicholas.alipaz’s picture

nicholas.alipaz commented

thanks for the commit. This will indeed be useful.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.