Download & Extend

Repeated list wrapper tags for last element of list

Project:Textile
Version:6.x-2.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This:

* 1
* 2
* 3

generates:

<ul>
<li>1</li>
<li>2</li>
</ul>
<ul>
<li>3</li>
</ul>

(In recent version of PHP.) The extra <ul> is Evil. See http://forum.textpattern.com/viewtopic.php?pid=157427#p157427 for details in the Texpattern forum.

The attached patch takes care of it.

(I've never submitted a patch before, so I'm not sure I did it right.)

AttachmentSize
fix_list_wrapper.patch617 bytes

Comments

#1

confirmed working.

#2

Likely cause:

The INSTALL.txt file of the textile module lists http://textile.thresholdstate.com/ as the first source of classTextile.php, but as of May 16 2010 http://textile.thresholdstate.com/ continues to provide an older version. That older version leads to problems such as the one noted in this issue.

To fix this problem on your Drupal site:

  1. Get the latest version of classTextile.php by downloading TextPattern sources from http://textpattern.com/download. classTextile.php is in textpattern/lib.
  2. Replace classTextile.php in your textile module directory with this new version.
  3. Clear your cache by pressing the "Clear cached data" button found at the bottom of your admin/settings/performance page.

To fix the textile module:

Looks to me as if references to http://textile.thresholdstate.com/ (outdated) and the subversion website (latest development version, which may be unstable) should be eliminated from INSTALL.txt, and that instead INSTALL.txt should recommend obtaining classTextile.php from the latest stable version of TextPattern sources at http://textile.thresholdstate.com/. Until INSTALL.txt is corrected those who try the textile module will tend to think it is buggy.

#3

Status:active» fixed

Created "INSTALL.txt points to out-of-date classTextile.php sources" http://drupal.org/node/802320 so that the multiplicity of issues caused by that problem may be set to status:fixed and eventually close.

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.