Comment threading broken

Same bug here. Using HEAD.

SQL query in comment_render() is normal. Any other instance for this bug?

The issue is being caused in comment_load_multiple. The array is loaded correctly in comment_render, however the order is forgotten when we load the comment collection. This patch introduces a new parameter that can be passed into comment_load_multiple to allow for orderby statements, and removes the original ordering in comment render as it does 'nothing'. Initial patch supplied to fix the issue.

Nice catch, but the correct fix is to make sure that comment_load_multiple() respect the order of the cids it receives, the same way that node_load_multiple() does respect the order of the nids it receives.

Untested patch which does that. Looks like we don't have tests for the order of threaded comments, hoping it might just be a couple of asserts / strpos in the existing tests.

Patch from #5 applied fine but problem still exists; followed steps from original post.

I've tested a patch - comments still posts under last thread.

Screens in my duplicate issue #529374: Reply on comment is broken

Change the operation on the array as we have 0 key and placement issues in the array

Tested #10 and comments were threaded as expected. Patch failed to apply, re-rolled from root.

This patch (#12) applies cleanly and now comments displays in right way.

+1 to rtbc this after bot happy!

Looks like everything fine and 3 opinions to rtbc

Sorry, but we will need some tests for this. Otherwise, we're likely to break it again.

This was nearly fixed by the entity patch. Only nearly, because a condition was wrong in DrupalDefaultEntityController::load(). We actually need to fix the ordering of the result set even when the cache is not enabled.

Here is a patch + test.

Very nice.

Awesome! Thank you very much. Committed to HEAD.