Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
forms system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Mar 2006 at 20:11 UTC
Updated:
14 Sep 2006 at 23:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
Steven commentedMost likely this is the Apache %2F bug which is worked around in core. A similar fix such as drupal_urlencode() would be needed for autocomplete.js.
Comment #2
Uwe Hermann commentedCannot reproduce in CVS HEAD. Can somebody confirm this is fixed? If yes, this can be closed.
Comment #3
sjanes71 commentedI still experience this bug with 4.7.2 and I consider it to be rather important for some of the data I'm using.
Comment #4
simeFound this problem using ecommerce 4.7 file.module in 4.7.2
http://urbits.com/_media/some_error.gif
Comment #5
simeMarked "won't fix" by killes in this thread.
http://drupal.org/node/7930
So I'll do the same here.
Comment #6
dman commentedSorry, a "won't fix" from 2004 doesn't address how critical this is to this years autocomplete.
Here's a patch (much simpler than the other proposed workaround) that just causes the AJAX requests to be made with ?q= notation rather than as a clean URL.
This is technically more correct than relying on mod_rewrite to do everything for us anyway.
Where my errors were:
(404) I now can use:
and things work again.
The change looks like this in the code of theme_textfield()
Attached patch is against 4.7.2. It appears problem persists in todays HEAD/CVS.
.dan.
Comment #7
killes@www.drop.org commentedmoving to cvs to increase exposure. The solution seems to be ok to me, the patch needs some coding style love.
Comment #8
dman commentedFair call, I guess, but meaning what?
Drop the explanatory comments, and I can't see the stylistic difference between the old and new syntax & layout. It only juggles the parameters to a function. Yeh it's an ugly big line, would it be clearer in two?
I'd be happy to accede, but I'm not sure how...
.dan.
Comment #9
Steven commentedUsing a clean URL for autocomplete is not a very clean fix. We should just mirror all the code in drupal_urlencode() to JS, work around all the Apache / mod_rewrite bugs (/, &, #) that way.
Better patch attached.
Comment #10
Steven commentedthat is 'using a non-clean URL' of course...
Comment #11
drummI'm getting a
warning: Missing argument 1 for user_autocomplete() in /home/drumm/drupal/drupal/C-HEAD/modules/user/user.module on line 2365.
Comment #12
Steven commentedWell, slashes don't actually work because they are indistinguishable from menu path slashes, and user_autocomplete() fails. I fixed that bug and merged this into the jQuery patch, as it changes all that code around anyway.
Comment #13
(not verified) commented