Over at #383500: List of users for quick switch is truncated, the Quick Switch feature was changed to store user names in the database instead of user ID's. This is a security issue as many sites allow users to change their own user name (it's a feature of the user module). I actually implemented a similar UI for the patch I'm about to post over at #290313: Limit to relative users, so the code for converting user names to uids and back will be there shortly.

CommentFileSizeAuthor
#2 521444_store_user_ids_quickswitch.patch4.2 KBdeviantintegral

Comments

deekayen’s picture

deekayen commented
Priority: Normal » Critical

I agree, user ids would be a much better way to do this.

see also #440252: Block Quick Switch users cannot be longer than 128 characters

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 521444_store_user_ids_quickswitch.patch4.2 KB

Here is a patch which fixes up the user storage, as well as a few minor indentation issues.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

I've committed the patch in #2, with a minor fix in the hook_update_N comment.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.