Disabling node feature doesn't remove the node type

I think the issue is that node types generated through enabling of the Feature are not considered 'custom'.. note that this bug occurs even when the feature is enabled and the node type is created (as opposed to the idea that it's just when one disables the feature that the Delete button disappears)

The magic around what node types have the 'Delete' link seems to happen around line 31 of content_types.inc in the node module in Drupal 6.13

      // Set the delete column.
      if ($type->custom) {
        $row[] = array('data' => l(t('delete'), 'admin/content/node-type/'. $type_url_str .'/delete'));
      }
      else {
        $row[] = array('data' => '');
      }

(as a test removing this check forces the 'Delete' link to appear on the Feature-generated node)

How to set the node type as 'custom' is beyond me, I am trying to work out how to export that as a parameter where the node type is defined in the 'module' that Features generates. Hopefully these are some clues for the developers.

Found a solution

Edit your $feature.defaults.inc, find the implementation of hook_node_info
Add an attribute to the array 'custom' => '1'

i.e:

/**
 * Helper to implemetation of hook_node_info().
 */
function _product_site_node_info() {
  $items = array(
    'product' => array(
      'name' => t('Product'),
      'module' => 'node',
      'description' => t(''),
      'has_title' => '1',
      'title_label' => t('Product Name'),
      'has_body' => '0',
      'body_label' => t(''),
      'custom' =>'1',
   ),
  );
  return $items;
}

I then installed this feature on a new test site (could've just reinstalled the feature on the same site I spose, but I wanted to test on a completely fresh db where the node type didn't already exist etc) and the 'Delete' button appears.

Hope it helps

Here's a patch for HEAD that works for me.

Hope it's ok (it's the first patch I've ever submitted :) )

I guess it doesn't address the issue's title of the node type not being removed when the feature is disabled. Maybe this should be two separate issues.

I might be doing something wrong.. I installed a fresh site (via Aegir), downloaded features and patched it as above, built a new feature with a simple new node type and applied this feature on another fresh site, that also had the features module patched just in case.

The implementation of hook_node_info does define the 'module' as 'features' as above,

/**
 * Helper to implemetation of hook_node_info().
 */
function _test_node_info() {
  $items = array(
    'test_node' => array(
      'name' => t('Test  Node'),
      'module' => 'features',
      'description' => t(''),
      'has_title' => '1',
      'title_label' => t('Title'),
      'has_body' => '1',
      'body_label' => t('Body'),
    ),
  );
  return $items;
}

but under Content Types on the site I deployed the new feature on, the delete option is still missing until I add 'custom' => '1' to that array and refresh.

Should I be testing this not on the latest stable but HEAD or something? Though the patch did apply cleanly.

Maybe I'm misunderstanding, if so please let me know if there's anything specific you'd like me to try - I'm very keen to help out testing and have lots of resources to do so :)

However, disabling the feature does now remove that node type, so your fix correctly addresses this issue's title (just not the 'delete' node option that was mentioned in the body, that my patch addressed). sorry for complicating the ticket as these are really two separate issues I guess.