Download & Extend
Send » Issues

send_setting can't install table in PostgreSQL - Syntax error

Posted by Josh Waihi on July 16, 2009 at 11:48pm
Project:Send
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This is because the column 'nid' specifies a 'length' but lengths are for string based data types. You can' t specify a length for int columns but you can specify a 'size' with possible values of small, normal (default) or large.

- 'length' => 50,

see #346450: Schema API: 'length' should be ignored on non varchar and char fields

Login or register to post comments

Comments

#1

Posted by stuzza on July 17, 2009 at 2:43am

Have attached a mighty one line patch addressing this.

AttachmentSize
send-346450.patch 564 bytes

#2

Posted by Josh Waihi on July 17, 2009 at 2:45am
Status:active» reviewed & tested by the community

Thanks @stuzza

#3

Posted by stuzza on July 17, 2009 at 2:55am
Status:reviewed & tested by the community» active

A colleague suggested it useful to ask why 'length' => 50 was specified in the first place. In the node_revisions table nid is defined as a standard int (in node table, of course, it's a serial). I note that numerous fields in the send_schema() are 'varchar' of length 50 so I'm guessing this was a typo rather than an attempt to specify int size.

Thoughts?

Stuart

#4

Posted by Josh Waihi on July 17, 2009 at 11:57pm
Status:active» reviewed & tested by the community

patch fixes problem, length doesn't need to be specified and replicating the nid column in the node table will keep things consistent.

#5

Posted by jerdavis on February 4, 2010 at 1:37am
Status:reviewed & tested by the community» fixed

#6

Posted by System Message on February 18, 2010 at 1:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here