Problem with code line 1032:

if ($result->code != 200 || strpos($result->data, 'Thank you for subscribing') === FALSE) {

- when phplist language is changed, strpos fails
- probably: when encoding in Drupal and phplist is different, can also fail in some cases (characters with diacritics etc.)

Should be changed to t() and encoding related - OR look directly into phplist DB and texts/{language}.inc to find out which string should be send back in case of success...

Comments

paulbeaney’s picture

paulbeaney commented
Assigned: Unassigned » paulbeaney
Status: Active » Needs review

Hi,

Thanks for flagging this one up. Looking directly into PHPlist text files will not be possible since the module is designed to allow PHPlist and Drupal to exist on completely separate servers.

I think the only way will be your other suggestion, namely to wrap it in a t() function and each Drupal system admin will have to provide the necessary translation via the usual means. I have implemented this in the latest D6-DEV release - can you try it and let me know if it works ok?

Regards,

- Paul

paulbeaney’s picture

paulbeaney commented
Status: Needs review » Closed (fixed)

Assumed fixed.