Part of the content type editing cleanup #521468: Redesign content type editing (after CCK UI is in) it become clear 'Minimum number of words' setting belongs to field settings: either 'long text with summary' or all the way 'long text'.
While at it, it would make sense to change the default value on display. Currently it displays:
Minimum number of words:
0
what might suggest the word limit is zero -- you can not add any words.
It's better to default something like:
Minimum number of words:
Unlimited
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 522184_remove_min_word_count-5.patch | 6.16 KB | stborchert |
Comments
Comment #1
bjaspan commentedFirst, "minimum number of words: 0" doesn't mean you can not add any words, it means you can add as few as zero words, ie: no minimum. "Minimum: Unlimited" is non-sensical. You are confusing minimum and maximum.
I have another suggestion for the minimum-words functionality: remove it completely, unless someone can provide a realistic use case in which it is genuinely useful. Note that it really is not useful for requiring a minimum number of words, because users can always enter "x x x x x x" or whatever. So I'm just not sure what the point is.
Comment #2
kika commentedAgree to remove the confusing setting. Contrib could hook into form and provide neccessary extra validation, right?
Comment #3
Bojhan commentedYup, sounds good to me to - I can only see its use in a fairly large site, where restrictions on text is to keep the workflow in the layout well.
Comment #4
bjaspan commentedComment #5
stborchertFirst patch. It completely removes "minimum number of words" from Drupal.
Comment #6
bjaspan commentedRTBC. I can't wait to see the reaction this gets. :-)
Comment #7
bjaspan commentedThis is no longer really a Field API change.
Comment #8
kika commentedWould it make sense to move this functionality to a contrib module?
Comment #9
bjaspan commentedPossibly, though I doubt anyone would ever use it. :-) In any case, that would not affect this patch to remove it from core.
Comment #10
dries commentedI agree that this can be removed. Committed to CVS HEAD. Thanks!
Comment #11
moshe weitzman commentedI think this came from Dries' desire to force posters write more thoughtful nodes in the early drop.org/drupal.org days. It is no longer in use according to http://drupal.org/admin/content/node-type/book. Glad to see this gone form core.
Comment #12
peterjmag commentedIn regards to #8 (keep functionality as a contrib module), here's a start: http://drupal.org/node/363623
#23 in that issue provides this module: http://cvs.drupal.org/viewvc.py/drupal/contributions/sandbox/davereid/co...
#26 is an example of a user that requires this feature, so maybe it'd be worth pointing this (or a similar module) out to D6->D7 upgraders?
Comment #13
kika commented> I think this came from Dries' desire to force posters write more thoughtful nodes in the early drop.org/drupal.org days.
We need "Long Gone Features" section in upcoming Drupal Museum.
Comment #14
dries commentedMoshe is right in #11. It was one of those things ... Like, Mollom 0.1. :-)
Comment #16
SpikeX commentedI realize this issue is long closed, but I just wanted to add that I do in fact use this feature. I don't care if it's contrib'd for D7, I just don't want to see this feature disappear entirely. :)
Comment #17
blueblade commentedme too..in fact, does anyone know how to get this feature for Drupal 6?
Comment #18
SpikeX commented@#17 Wow dude. Drupal 6 has that built-in, it's in the content type settings. This whole thread is about removing it for Drupal 7, implying that it was already in some previous version of Drupal to begin with.
Comment #19
blueblade commented@#18 oh sorry, do you know if this feature is available for CCK text field?
Comment #20
SpikeX commentedNo, I have no idea, but my guess is no if they're phasing it out of D7.
Comment #21
blueblade commented@#20, makes total sense....how sad...?
how are we going to stop users from posting one word articles? unfortunately I get a lot of those lol