Sun already uses the 'libraries' directory in sites/all/libraries' for his wysiwyg module. Probably more modules will use this namespace. To be consistent with other module I think we should also use 'libraries' instead of 'js_libraries'
Sun already uses the 'libraries' directory in sites/all/libraries' for his wysiwyg module. Probably more modules will use this namespace. To be consistent with other module I think we should also use 'libraries' instead of 'js_libraries'
Comments
Comment #1
skilip commentedComment #2
klonoshey skilip? You've marked this as fixed. Does this mean we'll have to rename the directory when the next dev is out? Or if we already have a 'libraries' directory, then should we move all contents of 'js_libraries' to 'libraries'?
If yes, can you please add a warning or something in the site status report to remind us upon upgrade to new version once changes are committed? Thanx in advance.
Comment #3
skilip commentedHi klonos,
Today I've released a new version which now uses 'libraries' over 'js_libraries'. On top of the project page I've added a big header "ATTENTION", which explains this. Do you think of another way to inform users?
Comment #4
klonosThank you for the update skilip and sorry for the late reply.
Your move is a nice step, but it only helps those that will visit the module's page and actually take a look at the warning. How about the people that simply see there is a new version of the module from their site's 'available updates' page and download it from the link provided there?
I think that the module should check for the existence of the js_libraries folder and if that returns true, it would inform the site admin. There are two cases here:
1. People already have both a 'libraries' as well as a 'js_libraries' folder. The warning should in this case be something like 'Releases of jQuery Plugin Handler higher than version 6.x-2.0 now use 'libraries' instead of 'js_libraries' for directories! Please copy your jQuery plugins from the 'js_libraries' directory to your 'libraries' directory. Once you do that, please remove your 'js_libraries' directory and this warning will go away.'
2. People have their 'js_libraries' folder, but no 'libraries'. In this case the warning should be 'Releases of jQuery Plugin Handler higher than version 6.x-2.0 now use 'libraries' instead of 'js_libraries' for directories! Please rename your 'js_libraries' directory to 'libraries' and this warning will go away.'.
That was what I had in mind.
Comment #6
klonosI hate saying 'I told you so!', but... told you so!...
#729640: upgrading to latest version requires a complete uninstall to accept the update
Ignored it back then and now it came back to bite us :)
If
../sites/all/librariesisn't there but../sites/all/js_librariesis (say after an upgrade from a version that required../sites/all/js_libraries), how about gracefully falling back to../sites/all/js_librariesand simply throwing a warning to the admin and in the site's Status report?The warning should be something like:
[If Libraries API is installed and a
../sites/all/librariesdirectory already exists][If Libraries API is not installed and there is no
../sites/all/librariesdirectory]Comment #7
sunIt shouldn't use the 'libraries' directory if it is not using Libraries API.
Comment #8
skilip commented@sun: why? Does it conflict in any way?
Comment #9
klonosI think it's a good practice for every module to start moving 3rd party libs to
../sites/all/librariesanyways.I see no harm in moving them out of the modules' folders. If Library API happens to be already installed or planned to be installed at some later point, then that would be a +. I don't thing that Library API should be a requirement though for that process though.