The function _insert_node_replacer should make use of theme_ functions wherever HTML output is generated. For instance, the return:

return '<div class="insert-node insert-node' . $insert_node_count . '">' . $output . '</div>';

could be:

return theme('insert_node_result', $output, $insert_node_count);

and then another function defined:

function theme_insert_node_result($output, $insert_node_count) {
  return '<div class="insert-node insert-node' . $insert_node_count . '">' . $output . '</div>';
}

This way, I could make my own theme override - like if i didn't want that div around the results, I'd define in my theme's template.php:

mytheme_insert_node_result($output, $insert_node_count) {
  return $output;
}

I may have made mistakes - but that's the general idea. This should be done everywhere HTML output is generated - either as a few big functions or several smaller ones.

Comments

AlexisWilke’s picture

matteusx,

You are correct, and actually every single output generator should be using a theme() call!

I'm working on it.

Thank you.
Alexis

AlexisWilke’s picture

Version: 6.x-1.1 » 6.x-1.x-dev
Assigned: Unassigned » AlexisWilke
Status: Active » Fixed
Issue tags: +theming

Matteusx,

Okay. This is done in the -dev version. Feel free to re-open this bug entry if you have some problems.

Please, make sure you read the Upgrade information on this page: http://drupal.org/project/InsertNode

You will see about 12 theme() calls in the new version. That should give you all the power you need to make all the options work the way you need them to work.

Thank you.
Alexis Wilke

Status: Fixed » Closed (fixed)
Issue tags: -theming

Automatically closed -- issue fixed for 2 weeks with no activity.