benshell's drupalimage/editor_plugin.js typo

I tracked it down to the javavscript in benshell's drupalimage plug-in for tinyMCE.
I have posted the solution to Benshell's thread (you need to go to page 2!) http://drupal.org/node/32506#comment-98581

Apologies if I'm posting in the wrong place here but it took me ages to track down and I thought I might find the answer amonst tinyMCE issues so maybe someone else will too (?).

note this only applies to the benshell's version of img_assist
briefly, it was a simple typo in the drupalimage/editor_plugin.js line 178 :

- tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonNormal');
+ function tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonNormal');

oops, the /*function*/ patch above doesn't quite fix the problem ... it restores functioanlity to the ordinary buttons, but stops the drupalimage button from appearing!

my latest attempt is this: remove that whole line!

so it should look like:

function TinyMCE_drupalimage_handleNodeChange(editor_id, node, undo_index, undo_levels, visual_aid, any_selection) {
	function getAttrib(elm, name) {
		return elm.getAttribute(name) ? elm.getAttribute(name) : "";
	}

//	tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonNormal');  /* it seems this whole line shouldn't be here! */

	if (node == null)
		return;

	do {
		// This code looks at the name of the image to see if the drupalimage button should be selected.
		// However, by default 'name' is not accepted by TinyMCE as a parameter for the img tag, so it must
		// be added using the initialization string.  As far as THIS code goes, it could look at 'className' 
		// instead, therefore avoiding this requirement, however the regular image button looks at the 
		// 'name' value to see if it starts with 'mce_'.  If it does, it considers it an internal image and 
		// does not highlight the regular image button.  If 'className' is used here instead, BOTH buttons
		// highlight when a drupalimage is selected.
		if (node.nodeName.toLowerCase() == "img" && getAttrib(node, 'name').indexOf('mce_plugin_drupalimage') == 0) {
			tinyMCE.switchClassSticky(editor_id + '_drupalimage', 'mceButtonSelected');
		}
	} while ((node = node.parentNode));

	return true;
}

This seems to work now - so far as I've tested it, both ordinary buttons and drupalimage button work as they should (better than ever! nice one Benshell!)

I just hope I haven't upset anything else!