Hi,
Thanks for this geate module !
I know that it is still in dev, but if you test the advanced demo on the jcrop page and read the manuel , you can see that there's some intertings options not present in the drupal module.

MinSize : Minimum width/height, use 0 for unbounded dimension
maxSize : Maximum width/height, use 0 for unbounded dimension
setSelect : Set an initial selection area

(there also bgColor or bgOpacity but wouldn't make any use of it)
Is there some plan to this to the module so that we could configure them for each imagefield_crop ?

CommentFileSizeAuthor
#11 imagefield_crop_min.patch4.17 KByhager
#9 imagefield_crop.js_522864_v2.patch3.15 KBquadbyte
#7 imagefield_crop.js_522864.patch665 bytesquadbyte

Comments

dotwired’s picture

dotwired commented

This is a very important issue for me. I love this module already, but a minSize Feature would make it perfect.

skizzo’s picture

skizzo commented

I second this request: if I understand it correctly, MinSize would make it possible for users to crop images, while enforcing a minimum "quality level" for the final image.

yhager’s picture

yhager commented

This would be a good feature - patches are welcome!

Bilmar’s picture

Bilmar commented

subscribing

CinemaSaville’s picture

CinemaSaville commented

Subscribing

robby.smith’s picture

robby.smith commented

+1 subscribing

quadbyte’s picture

quadbyte commented
Status: Active » Needs review
StatusFileSize
new imagefield_crop.js_522864.patch665 bytes

Here is my minimal take on 'minSize' to make it impossible to select an area smaller than the final output.
Tested on my side with and without 'enforce ratio'.
Hope that helps.

yhager’s picture

yhager commented
Status: Needs review » Needs work

@quadbyte - Thanks, looks good.
However, this will enforce minsize on everyone, based on the preview box size. Can you add a checkbox to the settings page that says: "Enforce minimum crop size based on the preview size".

Also, what happens if one adds a large image, that is being resized for cropping? I assume the crop box minimum size should be actually smaller, to reflect the real size of the image. Can you please check this (Jcrop might do it for us, not sure though).

quadbyte’s picture

quadbyte commented
StatusFileSize
new imagefield_crop.js_522864_v2.patch3.15 KB

@yhager - here is the improved version with a checkbox to enable the conditional minSize jCrop option.

I changed the wording a little as I find it confusing to use "preview" size and prefer "output" size. Hope the text are not too crappy ;)

And yes you are right, I did check : if one adds a large image, jCrop takes care of the overall scaling (image and cropping area) so there is no need for us to worry about it.

quadbyte’s picture

quadbyte commented
Status: Needs work » Needs review
yhager’s picture

yhager commented
Status: Needs review » Fixed
StatusFileSize
new imagefield_crop_min.patch4.17 KB

Thanks, committed.

I added validation and a correct default value. The patch that was committed attached.

I am marking this issue as fixed, as it seems that most people here wanted minSize. If you want maxSize or setSelect, please open another issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.