I confirmed the tests all work and made this a little more strict so that it confirms that the data is not only on the page, but in the right place. It also incorporates the settings from the issue to customize titles everywhere.

CommentFileSizeAuthor
#6 522900_more_tests_for_talk.patch3.44 KBgreggles
522502_preprocess_prefix.patch772 bytesgreggles

Comments

cwgordon7’s picture

cwgordon7 commented
Status: Needs review » Needs work

Wrong patch? :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Wow...I deleted the patch locally as well. I'll fix them up again and post.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Apparently the current simpletests are broken. We should fix at least that first.

cwgordon7’s picture

cwgordon7 commented

I had fixed the broken SimpleTests with http://drupal.org/cvs?commit=253036, more tests would be nice, but not necessary for a new release. Feel free to tag and create a new Drupal 6 release if you don't want to wait for more tests. :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Alrighty - great!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 522900_more_tests_for_talk.patch3.44 KB

And here we go - more tests.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Just committed - http://drupal.org/cvs?commit=260426

I feel like we probably have pretty decent coverage at this point so I'm marking this "fixed."

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.