array_multisort PHP warning when module failed to install

This occurs when there are no modules left to install during the form submission.

I.e. the sort array isn't empty, but the new modules array is.

See the attached patch.

E.g. if you don't have cURL support installed and try to enable simpletest, the bug will be triggered.

I made an oversight - it's not that no modules are installed, only that the arrays are different in size.

I.e. Previously, all selected modules are added to the $sort array regardless of being added to the $new_modules array (which contains modules that haven't failed validation).

I've tested conditions:
when there is only 1 module to enable, which fails validation.
when there is only 1 module to enable, which passes validation.
when there is multiple modules to enable, but some pass, some fail.

Try again... (testing)

+++ modules/system/system.admin.inc	5 Sep 2009 10:21:25 -0000
@@ -985,7 +985,10 @@
+        // Only add modules to enable, to $sort or array_multisort fails.

I can't quite parse that comment. Was the comma supposed to be there?

Also, when referring to functions you append (), so this should be "array_multisort()".

I'm on crack. Are you, too?

A few dupes of this issue:
#662950: array_multisort PHP warning when module failed to install
#660852: PHP warning generated if module fails hook_requirements() during enable

The comment should probably read something like

"Only add modules that will be enabled to $sort. array_multisort() requires a matching number of elements."

Thoughts?

Makes sense to me to put that comment above the else.

#1: system.admin_.inc_.no-modules-to-install.patch queued for re-testing.

#11: 523208.patch queued for re-testing.

I came across this bug when I tried to enable the simpletest module without fulfilling its cURL requirement. I made the same patch as #11, except I prefer if (condition) {) else {} to if (!condition) {} else {}. Also, with this re-ordering of the code, it's obvious just by reading it that we only wish to enable those modules whose requirements are fulfilled, and so there is no need for a comment.

I'm RTBC's #11 although I prefer my idempotent patch.

Adding tag.

Looks good to me (still).

does not apply anymore.

Having read the new system_modules_submit code, the reported warning when calling array_multisort should no longer be reproducible. Fixed by #592800-16: Dependent modules are still installed when required modules return errors in hook_requirements('install')