Took an initial look at Site information to cleanup some of the text.

Name = Site Name
The name of this website. = removed

Your site's motto, tag line, or catchphrase (often displayed alongside the title of the site). = removed, do we need to explain what a slogan is?

The maximum number of posts per page to display on overview pages like the front page above. = the maximum number of posts displayed on overview pages like the frontpage.

The last one I am uncertain about, we probally want to remove posts.

Comments

Bojhan’s picture

Status: Active » Needs review

Status

amc’s picture

Changes are small but streamline the page nicely. Tested this patch and it works.

dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

David_Rothstein’s picture

Status: Fixed » Needs review
StatusFileSize
new1.17 KB

Overall this is a good change, but:

  • "frontpage" should be "front page"
  • While it's true we don't have to explain what a slogan is, perhaps we should at least continue to explain how Drupal is going to use it - otherwise how will people know why they're being asked this information and whether or not they should bother providing it?

The attached patch is a suggested fix.

David_Rothstein’s picture

Of course, the whole Slogan thing is kind of a mess anyhow, since the default theme configuration that ships with Drupal does not even have the site slogan functionality enabled.

So basically no matter what you type in this box, it will never appear anywhere right now, unless you know where to go to change the setting that will make it appear....

Bojhan’s picture

Not sure, why your description is better then - no description. We could explain how its being used, but we could also not - if the design doesn't make it clear anyway.

amc’s picture

But doesn't how (or even if) the slogan is used depend on what theme you're using? I suppose we could just say that under the slogan entry: "How this is used depends on the theme you are using for your site." That way, if they don't see it at least there's a clue why...

David_Rothstein’s picture

Possible plan:

  1. Enable the site slogan theme setting by default on new installations (I have no idea why it's disabled by default - it's the only theme setting that is.)
  2. Rename the field from "Slogan" to "Site slogan", but leave the description off.
  3. Move the field up in the list, so it appears right underneath the site name.

That way there is a nice parallel between "site name" and "site slogan"; we don't have to provide descriptions, but if the user types something in either field and submits the form, they should get immediate and obvious feedback from the theme (if the theme supports it). Would work fine in Garland, at any rate.

David_Rothstein’s picture

StatusFileSize
new2.52 KB

A quick patch that implements this idea is attached.

David_Rothstein’s picture

StatusFileSize
new121.14 KB

And a screenshot - after installing Drupal and going to the site information page, entering something for the slogan gives you immediate feedback on the screen as soon as the form is submitted.

Garland's implementation of this is a bit funny looking, of course, but that's a separate issue :) The point is that by enabling site slogan support by default, any theme that implements it will provide quick visual feedback to the person who is submitting this form (and any theme that doesn't implement it... well, who knows).

David_Rothstein’s picture

Although I do also think @amc's suggested text might help here - since it does cover the case where the theme fails to implement it. Not in this patch at the moment, though.

Bojhan’s picture

Looks good. I think the text should be displayed on an IF statement, so IF slogan = disabled then show your slogan is disabled. Obviously depends on theme or themes

David_Rothstein’s picture

I was about to implement @Bojhan's idea in #12, but then thinking about it a bit more, as soon as we start saying something like "The site slogan is currently disabled in your theme", the next obvious step would be for someone to go to the theme settings page and try to enable it (in fact, someone would probably suggest that we link to that page from here). However, that would likely lead to chaos because of the complexity of the theme settings page -- confusion between global theme settings vs individual theme settings, themes that don't implement the site slogan possibility at all and therefore have meaningless "site slogan" checkboxes on that page, etc...

This made me think that @amc's suggested text in #7 might be cleaner - it automatically covers all cases and keeps them focused on typing in the site slogan, which is the main thing they are trying to do on this page. I'm happy to implement whatever the consensus is, though :)

Bojhan’s picture

Sure, but then if its enabled, we don't have to show it do we? I am assuming the 80% here, will have a slogan enabled by default. Not sure if Garland does? But a 1 theme scenario is likely.

dries’s picture

It seems like #7 is the preferred solution. It makes sense to have a theme without a visible slogan.

Gary Feldman’s picture

Could we change "overview pages like the front page" to "overview pages such as the front page"? I realize that the wording predates this change, but now seems like a good time to make it consistent with the Handbook usage recommendation.

Status: Needs review » Needs work

The last submitted patch failed testing.

David_Rothstein’s picture

Status: Needs work » Needs review
StatusFileSize
new1.98 KB

OK, rerolled this with text very similar to #7 and with the change from #16 as well. I think this is as good as its going to get :)

Bojhan’s picture

@David can you supply a screenshot?

David_Rothstein’s picture

StatusFileSize
new86.41 KB

Here is a screenshot from within the overlay (in the case of the overlay you don't get any visual feedback when you change the slogan, so in that case the help text might be even more needed).

xmacinfo’s picture

Status: Needs review » Reviewed & tested by the community

These are good cleanups for the Site information page.

Yes, please keep the new help text for the slogan.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Usability, -Needs text review, -ui-text

Automatically closed -- issue fixed for 2 weeks with no activity.