Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
18 Jul 2009 at 07:40 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Bojhan commentedStatus
Comment #2
amc commentedChanges are small but streamline the page nicely. Tested this patch and it works.
Comment #3
dries commentedCommitted to CVS HEAD. Thanks.
Comment #4
David_Rothstein commentedOverall this is a good change, but:
The attached patch is a suggested fix.
Comment #5
David_Rothstein commentedOf course, the whole Slogan thing is kind of a mess anyhow, since the default theme configuration that ships with Drupal does not even have the site slogan functionality enabled.
So basically no matter what you type in this box, it will never appear anywhere right now, unless you know where to go to change the setting that will make it appear....
Comment #6
Bojhan commentedNot sure, why your description is better then - no description. We could explain how its being used, but we could also not - if the design doesn't make it clear anyway.
Comment #7
amc commentedBut doesn't how (or even if) the slogan is used depend on what theme you're using? I suppose we could just say that under the slogan entry: "How this is used depends on the theme you are using for your site." That way, if they don't see it at least there's a clue why...
Comment #8
David_Rothstein commentedPossible plan:
That way there is a nice parallel between "site name" and "site slogan"; we don't have to provide descriptions, but if the user types something in either field and submits the form, they should get immediate and obvious feedback from the theme (if the theme supports it). Would work fine in Garland, at any rate.
Comment #9
David_Rothstein commentedA quick patch that implements this idea is attached.
Comment #10
David_Rothstein commentedAnd a screenshot - after installing Drupal and going to the site information page, entering something for the slogan gives you immediate feedback on the screen as soon as the form is submitted.
Garland's implementation of this is a bit funny looking, of course, but that's a separate issue :) The point is that by enabling site slogan support by default, any theme that implements it will provide quick visual feedback to the person who is submitting this form (and any theme that doesn't implement it... well, who knows).
Comment #11
David_Rothstein commentedAlthough I do also think @amc's suggested text might help here - since it does cover the case where the theme fails to implement it. Not in this patch at the moment, though.
Comment #12
Bojhan commentedLooks good. I think the text should be displayed on an IF statement, so IF slogan = disabled then show your slogan is disabled. Obviously depends on theme or themes
Comment #13
David_Rothstein commentedI was about to implement @Bojhan's idea in #12, but then thinking about it a bit more, as soon as we start saying something like "The site slogan is currently disabled in your theme", the next obvious step would be for someone to go to the theme settings page and try to enable it (in fact, someone would probably suggest that we link to that page from here). However, that would likely lead to chaos because of the complexity of the theme settings page -- confusion between global theme settings vs individual theme settings, themes that don't implement the site slogan possibility at all and therefore have meaningless "site slogan" checkboxes on that page, etc...
This made me think that @amc's suggested text in #7 might be cleaner - it automatically covers all cases and keeps them focused on typing in the site slogan, which is the main thing they are trying to do on this page. I'm happy to implement whatever the consensus is, though :)
Comment #14
Bojhan commentedSure, but then if its enabled, we don't have to show it do we? I am assuming the 80% here, will have a slogan enabled by default. Not sure if Garland does? But a 1 theme scenario is likely.
Comment #15
dries commentedIt seems like #7 is the preferred solution. It makes sense to have a theme without a visible slogan.
Comment #16
Gary Feldman commentedCould we change "overview pages like the front page" to "overview pages such as the front page"? I realize that the wording predates this change, but now seems like a good time to make it consistent with the Handbook usage recommendation.
Comment #18
David_Rothstein commentedOK, rerolled this with text very similar to #7 and with the change from #16 as well. I think this is as good as its going to get :)
Comment #19
Bojhan commented@David can you supply a screenshot?
Comment #20
David_Rothstein commentedHere is a screenshot from within the overlay (in the case of the overlay you don't get any visual feedback when you change the slogan, so in that case the help text might be even more needed).
Comment #21
xmacinfoThese are good cleanups for the Site information page.
Yes, please keep the new help text for the slogan.
Comment #22
dries commentedCommitted to CVS HEAD. Thanks!