Incorrect parent

hovel - July 18, 2009 - 12:15
Project:Imagemenu
Version:6.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:reviewed & tested by the community
Description

I have created two imagemenu's each with 5 underlying items.
When i want to edit an existing item in the second menu i get the parent selection list of the first menu.
When i create a new item in the second menu i get the correct parent selection list.

#1

hovel - July 25, 2009 - 08:29

I have found a solution to this problem. In function imagemenu_edit_item, when $type = 'edit', the menu id ($mid) is not used. Therefor the parents of the first menu are given. The attached patch solves this problem.
I am not fully aware of the requirements and internal logic of this module, so my correction may not be the best way to solve the problem. But it works.

Best regards,
hovel

AttachmentSize
imagemenu.admin_.inc_.patch 820 bytes

#2

techninja - August 21, 2009 - 05:57
Status:active» reviewed & tested by the community

Yep.. Same problem here, awesome job with the patch hovel, I should get in the habit more often myself =)

Why exactly are there no other posts here? So.. Does no one edits their imagemenus? or.. is this module so unpopular as no one cares.. I care!! hovel cared enough to make a patch! He's awesome!

The maintainer should probably have a look to make sure this is kosher before it gets thrown in, but yea, silly bug, easy fix.

#3

EastWan - September 14, 2009 - 16:42

Same problem here. Patch works just fine.

Thanks!

 
 

Drupal is a registered trademark of Dries Buytaert.