Not respecting comment approval permissions

ronan - July 19, 2009 - 04:40
Project:Mail Comment
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Because the status is being set on comments before being sent to comment_save, 'post comments without approval' is being ignored (ie: comments go live right away even for users without that permission). This patch unsets the status variable so that comment_save can add it back again based on the given user's permissions.

Thanks for the awesome module.
Ronan

AttachmentSize
comment_status.patch720 bytes

#1

Intertextual - August 4, 2009 - 13:25

I'm having a similar problem.

Comments are not being published (they stay in the approval queue) even when the permission are set to publish comments, and also publish comment without approval.

Cheers.

#2

Ian Ward - August 10, 2009 - 23:53
Status:needs review» fixed

Thanks for posting this. Committed. I prefer mail2web fallback on permissions as opposed to delegating to a command from mailhandler in this case. I believe you can accomplish everything you need based on permissions as you would using mailhandler commands to control this.

#3

System Message - August 25, 2009 - 00:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#4

Ian Ward - November 16, 2009 - 18:01
Project:Mail to Web» Mail Comment
Version:6.x-1.x-dev» 6.x-1.x-dev

Switch to mailcomment project. Mail2web is now known as "mailcomment" due to a trademark issue with the name mail2web.

 
 

Drupal is a registered trademark of Dries Buytaert.