Posted by ronan on July 19, 2009 at 4:40am
Jump to:
| Project: | Mail Comment |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Because the status is being set on comments before being sent to comment_save, 'post comments without approval' is being ignored (ie: comments go live right away even for users without that permission). This patch unsets the status variable so that comment_save can add it back again based on the given user's permissions.
Thanks for the awesome module.
Ronan
| Attachment | Size |
|---|---|
| comment_status.patch | 720 bytes |
Comments
#1
I'm having a similar problem.
Comments are not being published (they stay in the approval queue) even when the permission are set to publish comments, and also publish comment without approval.
Cheers.
#2
Thanks for posting this. Committed. I prefer mail2web fallback on permissions as opposed to delegating to a command from mailhandler in this case. I believe you can accomplish everything you need based on permissions as you would using mailhandler commands to control this.
#3
Automatically closed -- issue fixed for 2 weeks with no activity.
#4
Switch to mailcomment project. Mail2web is now known as "mailcomment" due to a trademark issue with the name mail2web.