By definition, modules should define functions named modulename_functionname(), so drupal.module is expected to define functions drupal_anything(). This is confusing, since there are a lot of drupal_anything() functions defined elsewhere (common.inc and bootstrap.inc specifically). This leads to some confusion if you are searching for a function's implementation.

The naming of drupal.module also suggests that it is an integral part of drupal's inner workings, however it is not the case. It is rather a glue between the drupal.org site and the drupal instance. Therefore I would suggest renaming the module to drupalorg.module.

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Would a patch

  • modifying drupal.module function names to start with drupalorg_
  • modifying update.php to update drupal.modules data as with aggregator.module

have a chance being accepted? Also given that someone will rename drupal.module to drupalorg.module after the patch gets accepted. I stronly beleive that it is wrong to have two competely different sets of functions with the same prefix.

Steven’s picture

Steven commented

Drupal module is not limited to Drupal.org though: it handles pinging Drupal sites (you can make your own list if you want), Drupal authentication, ...

Drupalorg suggests it's only useful for Drupal.org.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Better name suggestions? I guess the name should reflect that this module handles the 'distributed' tasks between Drupal installations (authentication from another Drupal site, pinging Drupal.org and/or other sites)...

What about drupalnet.module ? :) Not referring to a web address of course.

moshe weitzman’s picture

moshe weitzman commented

drupalnet sounds jst right to me. more importantly, i think this calrifies the services provided by current drupal.module

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Assigned: Unassigned » gábor hojtsy
alexandreracine’s picture

alexandreracine commented
Version: x.y.z » 4.5.0

Too old version (x.y.z?). Closing.

alexandreracine’s picture

alexandreracine commented
Status: Active » Closed (fixed)
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 4.5.0 » 6.x-dev
Assigned: gábor hojtsy » Unassigned
Status: Closed (fixed) » Active

This might be for a too old version, but the problem still applies. Drupal core functions have drupal_ prefixes and the drupal module mixes into this with it's own functions. Moving up to 6.x

alexandreracine’s picture

alexandreracine commented

Good enough.

pwolanin’s picture

pwolanin commented

patch at: http://drupal.org/node/29826

will mark this issue as duplicate in a few days.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Closed (duplicate)
senpai’s picture

senpai commented
Status: Closed (duplicate) » Fixed

Completely fixed by http://drupal.org/node/178768

drupalorg.module is now a contrib. [EDIT: Based upon Kbahey's comment in #13, I removed this text. ~Senpai]

kbahey’s picture

kbahey commented

Just for those who may get confused.

The drupalorg.module is a completely different module.

The correct module is http://drupal.org/project/site_network which is now in contrib.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.