Hi Rob,

thanks for this nice module which I just installed for use with embedded media field. It works fine. But there is a little feature missing which is very importand for use this module together with emfield: The Scale Property of Flowplayer is default set to "scale" which means that the video is scaled to the window size. When viewing a video in full screen mode the video is stretched/distorted to the aspect ratio of the monitor, same happens when a video does not fit to the dimensions defined in embedded media field configuration. Setting the clip-option "scaling:fit" avoid this problem.

I've added the option to select scaling from the admin form. Could you please please put this to your Code. Sorry I'm not that professional coder to provide a patch.

best regards
Jürgen Brocke

added to flowplayer.admin.inc Line 20:

  // add option for scaling property
  $form['flowplayer_scaling'] = array(
    '#type' => 'select',
    '#title' => t('Scaling'),
    '#options' => array(
      'fit' => t('fit to window'),
      'half' => t('half size'),
      'orig' => t('original size'),
      'scale' => t('scale'),
    ),
    '#description' => t('The <a href="!options">Scaling-Property</a> for the video:<ul><li>fit: Fit to window by preserving the aspect ratio encoded in the video metadata.</li><li>half: Half-size (preserves aspect ratio)</li><li>orig: Use the dimensions encoded in the file. If the video is too big for the available space, the video is scaled using the fit option.</li><li>scale: Scale the video to fill all available space. Ignores the dimensions in the metadata. This is the default setting.', array('!options' => 'http://flowplayer.org/documentation/configuration/clips.html')),	
    '#default_value' => variable_get('flowplayer_background_gradient', 'scale'),  
  );

added to flowplayer.module Line 124:

	  // Merge scaling option in the defaults
      $scaling = variable_get('flowplayer_scaling', NULL);
      if (!empty($scaling)) {
        $config[clip]['scaling'] = $scaling;
      }	

added to flowplayer.install Line 15:

	variable_del('flowplayer_scaling'); 

Comments

prodigal_son’s picture

Thank you very much for these modifications Jürgen. Worked perfectly for our site.

-Julius

robloach’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ñull’s picture

Category: feature » bug
Status: Closed (fixed) » Needs review
StatusFileSize
new1.06 KB

There is a little bug as it uses the wrong variable_get. Attached a patch that corrects it and works fine here.

robloach’s picture

Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Yup! Thanks a lot for the help. I'll commit this today.

robloach’s picture

Status: Reviewed & tested by the community » Fixed
ñull’s picture

Yup! Thanks a lot for the help. I'll commit this today.

Could you please commit my wmode feature patch too.

robloach’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Fixed » Patch (to be ported)

For sure! We'll talk about it in #529036: Option to control "wmode" :-) .

jbrown’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Priority: Critical » Normal
Status: Patch (to be ported) » Needs review

We should default to 'fit'.

All the other options are incorrect anyway.

jbrown’s picture

StatusFileSize
new2 KB
robloach’s picture

Status: Needs review » Fixed

Although the Flowplayer scaling documentation lists "scale" as the default, "fit" makes more sense, otherwise it ignores the aspect ratio and we end up with oddly shaped videos. Thanks Jon!

http://drupal.org/cvs?commit=326566
http://drupal.org/cvs?commit=326574

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

keti-1931’s picture

is there any plans for drupal 7 i m facing same issue in IE