Closed (duplicate)
Project:
ShareThis
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Jul 2009 at 22:25 UTC
Updated:
26 Jan 2010 at 14:38 UTC
I thought it was something in my theme or a module interfering but even on a clean site with no extra modules the pop randomly works in IE7. I can refresh the page 50 times and 40 times it doesn't work. I see the other IE bugs in the issue queues but it seems like all have a fix added to the latest release. I have the latest release but it is still broken.
Comments
Comment #1
ngreenup commentedI have been going crazy thinking I am doing something odd. I made ANOTHER totally clean drupal install with NO MODULES and no themes. All I did was install sharethis, add it to page content type, create a page with a title and one word in the body. I click on sharethis in IE and nothing ever pops up.
Comment #2
ngreenup commentedUPDATE** I have actually gone back one version and it works 99% of the time in ie7... I will do more testing and report back on IE8 and IE6.
Comment #3
robloachIt would be better to fix this in the upstream. All my testing with both IE6 and IE7 worked fine. Could you test with 6.x-1.x-dev? Thanks!
Comment #4
Emmental commentedI also have the same problem. I tested with 6.x-1.x-dev on a fresh install and cannot get the pop-up to appear (ever) with IE7.
The odd thing is, I had a previous test site on which it was previously working 100% of the time (just not on live), but after setting up a new test site, it now doesn't work on any of them (old test, new test, or live). It works flawlessly in Firefox on all sites.
My new, clean test site is at http://emmental.dyndns.org/drupal/ If that does work for you then it must be something local.
Edit: I have a bit more information here which may help. I was looking for other options to do this and came across AddToAny (http://drupal.org/project/addtoany), which is a similar module. If I install and enable that module, then ShareThis starts working perfectly in IE7. If I disable AddToAny again, ShareThis stops working in IE. ShareThis always works in Firefox during this test. I've left the test site with only ShareThis installed, currently non-working for IE, in case you want to check it there.
Comment #5
robloachIs it working now? Seems to be workingo n this end with http://emmental.dyndns.org/drupal/ .
Comment #6
Emmental commentedNo it still doesn't work from for me in IE, so that's very odd. It looks like it may be something here then. Maybe some setting in IE, though I have reset that back to its default settings.
Comment #7
robloachI'll hit a couple of other issues and make a 1.6 release, while keeping my fingers crossed. If that doesn't work, I'll open up a 2.x branch using the straight embed code instead of their JavaScript API. Thanks a lot.
Comment #8
friolator commentedHas this been resolved? we're using version 1.6 and the popups never work in IE. They're fine in Firefox and Safari, but neither IE 7 nor IE 8 work at all. In IE 8 running on Windows XP, I get this error:
Comment #9
friolator commentedUpdate - it's no longer working in Firefox and Safari (that's what I get for making assumptions!). In Firefox, this is the error I get:
I think the problem here is that ShareThis has recently updated their widget. I got an email from them about this on the 18th. presumably the javascript code has changed since then.
The popup works fine if we put the script that ShareThis provides directly into the theme, so that's what we're going to do for now, until this is fixed.
Comment #10
robloachCould you please upgrade to 6.x-2.x-dev and Service Links 2.x-dev? I believe this is fixed in there.
Comment #11
friolator commentedis the 2.x dev pretty stable? we're on the cusp of launching this site, so I really hate to suddenly add in a dev release at this late stage.
Comment #12
gettysburger commentedI updated to the 2.x dev, installed Share, Share This Widget and Service Links and finally got it working, but now I get this error:
warning: array_filter(): The first argument should be an array in /srv/www/htdocs-test/sites/all/modules/service_links/service_links.module on line 334.
I have run update a few times but still get this error. Thanks.
Comment #13
robloachfriolator: If you're using this on a client's site, then that means that you have some time to help fix the problem. Put some resources into the modules your using and help polish them off. If you test out 6.x-2.x-dev of both Service Links and ShareThis, make bug reports, submit some patches, etc, then I'm sure a stable release wouldn't be too far off! :-)
gettysburger: Make sure you visit the configuration settings and set up what Service Links to show. With 2.x, you'd need to move ShareThis up there.
Comment #14
gettysburger commentedThanks. I've played around with Service Links settings and the error has gone away, but that now it opens Share It in an entire page. The small widget goes away. I have found how to open the new page in the same/different window, but I don't want a page, just the little widget. Where would I set that? Thanks so much.
Did a little more testing. On the Service Links page:
Service links in links: Disabled
Service links in nodes: Full-page view
Results: Share This in links opens widget on rollover
Service links in links: Full-page view
Service links in nodes: Full-page view
Results: Share This in both opens widget on rollover
Service links in links: Full-page view
Service links in nodes: Disabled
Results: Share This in link opens full page on mouseClick
WHAT I WANT:
Service links in links: Full-page view
Service links in nodes: Disabled
Results: Share This in link opens widget on mouseClick
Comment #15
friolator commentedsorry - we can't run dev builds on this site, especially since we're going live today -- too risky. we're just going to manually insert the sharethis code where we need it, and I'll try out the new version on a dev server after we've launched.
Comment #16
anonsee http://drupal.org/node/619964
Comment #17
robloachAnon is a hero. Please see #619964: Javascript errors on IE, FF, Safari as his fix was committed and update to ShareThis 6.x-1.7.