Allow to re-order "Attached Images" field in CCK content-type field configuration

I think you mean the CCK manage fields page.
Could you confirm the paths you mean?

oomph. Either this no-brainer gets in within the next 4 weeks or we'll close this issue.

Someone who has time could just copy how I implemented the CCK hook in image.module.

Please test attached patch.

Thanks for reporting, reviewing, and testing! Committed to 6.x-1.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Oops. Meant to test.
What I wanted to say is -- should it really say 'Image Attach settings'? Is the UI meant to represent form fields or the node display?

Is the description displayed at all?

Yes, but actually it's like this:

Title   	
	Node module form.
 
Menu settings 	
	Menu module form.
 
Image Attach 	
	Image Attach settings.
 
Body 	
	Node module form.
 
File attachments 	
	Upload module form.
 
test 	
	field_test_text

Could maybe change it to "Image attach module form." for consistency with the core items.

ok, then I'd actually propose:

s/Image Attach/Attached image/

s/Image Attach settings/Image Attach (module) form/

Not sure about the "module" in the latter. My take is that no end-user should be faced with any terms/strings like "module" (cruft + weirdness).

Looks good.
I sort of see why they've put in 'module' -- so you don't go wondering why there aren't any settings for those rows of the table. I see your point, but I also think we should stay consistent with what is already there.

#524646 by joachim: Changed hook_content_extra_fields() for Image Attach.

Committed a fix.
Kept the 'module' to be consistent with what CCK provides for core.

Committed a fix.

May I kindly ask whether you can attach a patch that contains the committed changes in such cases? That would be awesome! :) (no more required for this issue)

So -- what level of commit requires a patch and what doesn't?

Uhm, keep it simple:

- Issues with patches of others, just commit. If you made changes/corrections before commiting, then just attach a new, improved patch while marking the issue fixed. (A fine way for new contributors to compare their own patches with your patch and learn from that.)

- When directly committing changes, and there is an issue, then attach the committed changes as patch to that issue while marking it fixed. (Mostly for reference, in case someone else wanders through the changelog and wonders what a change was about.)

- In case there is no issue and you're committing a minor quick fix, then, well, nothing. (The changelog just gives a clue that something happened - viewvc resp. cvs log history to the rescue.)