Posted by roger6106 on July 20, 2009 at 8:59pm
| Project: | Audio |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
The audio module should try to detect if the user has flash installed. If flash is not installed, the direct listening link should be given in place of the flash player (ex. http://example.com/audio/play/608). Currently people without flash installed are forced to download the file using the download link, and then play the file. People using devices such as the iPhone are not able to play the file at all since it cannot download files.
Comments
#1
This patch provides a link to listen to the mp3 if flash is not installed, allowing users to listen to the files on iPhones. I have done some testing in different browsers, and although this isn't always pretty, it seems to work.
Warning: this patch shows the listen link even if the file is not set to downloadable. This can allow users to easily download the file. I do not currently have the time to figure out where the option to make the file downloadable is stored. This would need to be fixed before the patch is included into the audio module.
#2
Could you show me how to patch this module? I tried to do it, but having no luck, and really need this feature.
Thanks!
#3
Navigate to the audio module folder, then the players folder. Replace the .inc files with the attached files.
Note that everything should still look the same if you are using a computer that has flash installed. The link should only appear if you visit on a device without flash. Also, it appears that search engines will follow the listen link, incrementing the listen counter.
Edit: attached the wrong files. See comment below.
#4
I've done this, but it doesn't seem to have any effect. Did I need to apply the patch, and replace the players?
#5
Somehow I uploaded the wrong files. Here is a corrected patch and the corrected files.
#6
Here is a patch that does some permissions checking and which should be using the correct variable for the link URL (note that it's different for 1pixleout and the other players).