Closed (won't fix)
Project:
Drupal core
Version:
6.13
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2009 at 22:31 UTC
Updated:
20 Jul 2009 at 22:39 UTC
Hi,
Here is signature of system_clear_cache_submit function (declared in /drupal/components/system/system.admin.inc:1360).
function system_clear_cache_submit(&$form_state, $form) { // drupal-6.12
function system_clear_cache_submit($form, &$form_state) { // drupal-6.13
Arguments have been switched, making other third party modules such as modules/admin_menu crash php with following error message:
Fatal error: Only variables can be passed by reference in /drupal-6.13/sites/all/modules/admin_menu/admin_menu.inc on line 536
Enclosed proposed patch simply restore previous function signature.
Regards,
Remy
| Comment | File | Size | Author |
|---|---|---|---|
| system.admin_.inc_.patch | 364 bytes | remy.damour |
Comments
Comment #1
damien tournoud commentedThe correct signature is the new one. The change was unfortunate (admin menu is already fixed), but contrib modules shouldn't directly call a form submit handler of a core module ;)