Hi,

Here is signature of system_clear_cache_submit function (declared in /drupal/components/system/system.admin.inc:1360).

function system_clear_cache_submit(&$form_state, $form) { // drupal-6.12
function system_clear_cache_submit($form, &$form_state) { // drupal-6.13

Arguments have been switched, making other third party modules such as modules/admin_menu crash php with following error message:

Fatal error: Only variables can be passed by reference in /drupal-6.13/sites/all/modules/admin_menu/admin_menu.inc on line 536

Enclosed proposed patch simply restore previous function signature.

Regards,
Remy

CommentFileSizeAuthor
system.admin_.inc_.patch364 bytesremy.damour

Comments

damien tournoud’s picture

Status: Active » Closed (won't fix)

The correct signature is the new one. The change was unfortunate (admin menu is already fixed), but contrib modules shouldn't directly call a form submit handler of a core module ;)