First: thank you for this very interesting module.

Second: a bug report :)

When exporting exportables to a feature, in "Step 3: confirm components" there is an option to add extra "Module dependencies", which I used.

Now, after tweaking some CCK definitions and views, I chose "update" to get an updated feature tarball.
Apparently the additional module dependencies are lost from the info file,
as illustration, the diff of my info file:

-version = "0.2"
+version = "0.3"
 features[content][] = "project-field_date"
 features[content][] = "project-field_images"
 features[content][] = "project-field_location"
-features[dependencies][] = "date_api"
-features[dependencies][] = "date_popup"
-features[dependencies][] = "filefield"
-features[dependencies][] = "imageapi"
-features[dependencies][] = "path"
 features[imagecache][] = "lightboxpopupsize"
 features[imagecache][] = "square200"
 features[imagecache][] = "thumbnail"
 features[node][] = "project"
 features[views][] = "projects"
 dependencies[] = "date"
-dependencies[] = "date_popup"
 dependencies[] = "features"
 dependencies[] = "imagecache"
 dependencies[] = "imagefield"
 dependencies[] = "lightbox2"
 dependencies[] = "node"
-dependencies[] = "path"
-dependencies[] = "taxonomy"
 dependencies[] = "text"
 dependencies[] = "views"

Comments

Anonymous’s picture

Anonymous (not verified) commented

I'm tracing this problem and I've found the following:

  • features[dependencies][] = "mymodule" does not result in mymodule being a dependency of the feature module.
  • for features[dependencies] to work, there would need to be a dependencies_features_api function that is an implementation of hook_features_api.
  • modules that are added directly to the module info's dependencies[] array are obliterated on updates.
moshe weitzman’s picture

moshe weitzman commented
Priority: Normal » Critical

Thats pretty unexpected IMO.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

subscribe

yhahn’s picture

yhahn commented
Assigned: Unassigned » yhahn

Agreed - the change will probably disallow features from automatically removing any dependencies, meaning that if you've changed your feature such that it no longer depends on a module you'll need to remove the dependency manually.

Sound reasonable?

Anonymous’s picture

Anonymous (not verified) commented

yhahn:

It sounds reasonable to me.

yhahn’s picture

yhahn commented

This should be addressed by this rather massive commit: http://drupal.org/cvs?commit=262446

I would love to get some 2nd eyes on this to make sure the changes are relatively bug free.

yhahn’s picture

yhahn commented
Status: Active » Closed (fixed)

Closing. This is now fixed.