toolbar_install() creates the admin_shortcuts menu,
there should be a toolbar_uninstall() that removes it.

Currently, reinstalling toolbar with devel.module causes a fatal error:
"Duplicate entry 'admin_shortcuts' for key 1"

CommentFileSizeAuthor
#10 526818-toolbar-uninstall-missing-3.patch531 bytesdavyvdb
#2 526818-toolbar-uninstall-missing-2.patch1.82 KBclemens.tolboom
#1 526818-toolbar-uninstall-missing.patch1.93 KBdavyvdb

Comments

davyvdb’s picture

davyvdb commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new 526818-toolbar-uninstall-missing.patch1.93 KB
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Needs work
StatusFileSize
new 526818-toolbar-uninstall-missing-2.patch1.82 KB

* Fixed some tabs
* Removed function todo
* Added empty line EOF

I'm not sure how long lines may be ... 255 chars seems a little too long :)

Code seems to work fine.

davyvdb’s picture

davyvdb commented
Status: Needs work » Needs review
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Just changing the status does not help much ... do you agree / disagree with my patch ? Long line ?

If yes this could be RTBCed :)

davyvdb’s picture

davyvdb commented
Status: Needs review » Reviewed & tested by the community

It's just my patch + code cleanup. So yes I agree :D

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Um. Ick. :) Let's please make an API function for this and call it from both here and http://api.drupal.org/api/function/menu_delete_menu_confirm_submit/7.

alexanderpas’s picture

alexanderpas commented

subscribe

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Postponed

#473082: Add custom menu API adds the menu API function we need. Marking postponed on that.

asimmonds’s picture

asimmonds commented
Status: Postponed » Needs work

#473082: Add custom menu API was committed on 9th Oct. Marking needs work.

davyvdb’s picture

davyvdb commented
Status: Needs work » Needs review
StatusFileSize
new 526818-toolbar-uninstall-missing-3.patch531 bytes

This patch uses the menu api.

Status: Needs review » Needs work

The last submitted patch, , failed testing.

Status: Needs work » Needs review

Re-test of from comment #2402232 was requested by @user.

alexanderpas’s picture

alexanderpas commented
Status: Needs review » Needs work

This needs some tests.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Closed (works as designed)

This is no longer relevant - the toolbar module does not install anything anymore.