Now that Zen 6.x-2.x has broken the giant zen.css into bite-size bits, we no longer need the non-standard CSS formating to make the CSS readable in a really, really long file.

We're almost there now, but we need to make sure that we completely follow the CSS Coding Standards: http://drupal.org/node/302199

We can also help shape those standards by having another round of discussions.

Comments

alanburke’s picture

alanburke commented

Hi John,
I'm the guy who started that page,
but didn't finish the job :-(

It should have started with the discussion on GDO really, which then should have led to the standard.
By doing it the other way around [create page first, then have the discussion, I angered a lot of people, but then again, I got some discussion going pretty quickly :-) ]

I'm not sure where the process should go.
How about...
Take whatever consensus is on that page, and update the coding standards page.
Start a new discussion on GDO on remaining issues.
Don't try to add rules where NO consensus is emerging?

Regards
Alan

turadg’s picture

turadg commented

Those standards say to use CSSDoc for comments. Would you also consider using the "@group" doc attribute introduced by CSSEdit?

http://www.viget.com/inspire/organizing-your-stylesheet-using-css-edit/
http://cssdoc.net/wiki/CssEdit

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Fixed

Besides the CSSDoc comments and the alphabetical ordering of properties (which were the controversial bits), this is complete.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

FYI, the reason I'm not converting all the selector-based comments into CSSDoc comments are because CSSDoc comments take up way too much space.

For example, if I converted the blocks.css file to use CSSDoc comments, the file would be over twice the length it is now.

And there is no benefit to using CSSDoc comment formatting over any other arbitrary comment formatting standard. Because there are no tools that I know of that make use of CSSDoc.

For now Zen will use:

.selector,
.selector2 /* comment about selectors */ {
  property: value; /* comment about particular property */
}

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.