Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The links to add a new item directly related to an item don't work on most items.
Organization links work fine as they direct to /node/add/stormperson?destination=node/x&organization_nid=x
However Project and Task links lack the ending filter and Tickets have no links
I've patched the existing project links as well as adding a link for Expenses and am working on the others. I will post the patches here once finished.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | stormorganization-527768-9.theme_.inc_.patch | 5.65 KB | Mark_Watson27 |
| #9 | stormproject-527768-9.theme_.inc_.patch | 3.59 KB | Mark_Watson27 |
| #9 | stormtask-527768-9.theme_.inc_.patch | 2.88 KB | Mark_Watson27 |
| #9 | stormticket-527768-9.theme_.inc_.patch | 1.63 KB | Mark_Watson27 |
| #9 | storm-527768-9.patch | 9.66 KB | Mark_Watson27 |
Comments
Comment #1
Mark_Watson27 commentedPatches attached
Comment #2
Mark_Watson27 commentedAmmendment for stormticket, wasn't listing timetrackings correctly
Comment #3
Magnity commentedAll committed.
The links are starting to get a bit cluttered - especially for organisations. Any ideas - please post.
Comment #4
Mark_Watson27 commentedHello,
I see your poing and the links will get more cluttered with the addition of features.
Maybe reduce the icons to 16x16 and put them in a toolbar?
Or keep them at 32x32 but put them horizontally, remove the text and put in tooltip?
I'll have a little play if it's okay and maybe give people the option for how they want it displayed?
Thanks
Mark
Comment #5
Magnity commentedSounds great, thanks.
Comment #6
Mark_Watson27 commentedHello,
I've made a start on this issue. The first step I've taken is to remove some of the code duplication for the generation of the links by creating a theme_storm_icon function in storm.theme.inc and updating the theme files for organization, project, task and ticket.
I've attached the patched files for review.
Once you're happy I can then look in to changing the icons and stylesheet to present them differently.
Thanks
Mark
Comment #7
Magnity commentedSeems good
Minor points:
- I wonder if conceptually the argument source module should come before destination module?
- Would this new theme function be useful also for the Storm Dashboard?
Comment #8
Mark_Watson27 commented- Agreed source should be before destination, I'll change and update.
- I don't see why not, probably could use it on the timetracking invoice links as well.
I'll make changes and re-post the patch
cheers
Mark
Comment #9
Mark_Watson27 commentedHello again,
I've swapped the source and destination and altered the function to handle the Dashboard.
Please find patches attached.
Thanks
Mark
Comment #10
Magnity commentedReally good - just committing these. I really like the amount of code we're saving here.
As you've said you're going to look at the styles also i'm putting this back to active for now.
Thanks,
Comment #11
Mark_Watson27 commentedHello,
I've just downloaded the latest dev but it doesn't include the patches, is it me?
Cheers
Mark
Comment #12
Magnity commentedThe drupal.org packaging script runs twice a day for -dev releases, so they will appear in there from midnight.
If you want an up to date copy of the code, you can do a checkout from CVS (see http://drupal.org/node/253481/cvs-instructions/DRUPAL-6--1).
Comment #13
Mark_Watson27 commentedSorry, only just started coding Drupal so don't know the ins and outs!
I'll check out CVS although as it's now ticked past midnight I might not have to :)
Cheers
Mark
Comment #14
Magnity commentedThat's absolutely fine - its good to have you on board.
I suspect (although to be honest am not 100% sure), that drupal.org is not set to summer time, so to confuse matters, the next update will probably be at 1am. Also, this is the time that the script starts - it updates all dev releases hosted on drupal.org, so it may well be slightly after that when the script gets to the Storm release.
Comment #15
homoludens commentedregarding comment #4: I'm just not for removing text and moving it to tooltip - It may be optional, but please not default. Reason is learning curve, it is very confusing for beginners to see only images w/o text - and checking out every tool tip is time consuming.
btw, great changes.
Comment #16
Mark_Watson27 commentedI've been thinking about the GUI and how to acheive a consistent look and feel across the application.
]
Each module has it's own main icon, which we could put in a toolbar/menu (some examples http://plugins.jquery.com/project/Plugins/category/44)
But we also need a way to have actions on each item which should look different to the main module links above. I think these links should be available on both the form and list (see [#527982#).
We could layer action operations on top of the main main module icons, i.e. a plus sign on top of the timetracking icon to add a timetracking item. But we still need a way to differentiate between doing this as a standalone operation or something that is linked to the item you are viewing.
Any ideas on how we can seperate the two?
Comment #17
Magnity commentedI've forgotten exactly where we'd got to on this issue and whether I needed to put any more input in.
It seems the remaining topic was thinking about reducing the page space taken up by the links on node view, whilst keeping enough text to be user friendly.
Perhaps even, @jurgenhaas' Storm Dashboard module will now remove the need for this.
With regards to adding a Storm node as a standalone operation, or linked to the current item, perhaps this is where a tooltip could be used. 'Add ticket for this task' etc.
Comment #18
Mark_Watson27 commentedYeah, I sort of held back on this due to @jurgenhaas storm_dashboard as it seems to handle the UI pretty well.
That said I may still take a look a this as I think it would help
Comment #19
Magnity commentedThe core feature that this issue was about has been fixed - marking in status.
If we want to progress with compacting the node view links, then this can now be a separate issue.