Hi longwave,

Just getting into looking at your module's code. There's one feature that I need which I don't think it's currently supported, and just checking in with you on what you think and how hard might it be to implement it (I am hoping to do it myself). I need somehow to specify which attributes has VAT and which ones doesn't.

For instance, gift wrap should always have VAT independent of the product's setting (whether the product has it's tax rate rule applied or not). I am considering doing this as a special module, but better if we can come up with a more complex/flexible solution that can cover a lot more user cases. From what I looked at your code (not a lot for the moment), there seems that I would need to handle all the configuration of assigning VAT to attributes by myself (there's not such thing in the ubercart tax admin screens, although it might be good to have it there). And after that, somehow, work over the logic of altering prices depending on this settings.

Any ideas?

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't think this will be possible without support in core uc_taxes for individual tax rates for attributes, as uc_vat is only responsible for displaying tax-inclusive prices, it's uc_taxes that actually applies them to the final order. Is there any reason you can't have gift wrap as a separate product/product class? This would let you implement the tax rules with no changes required to any module. There is also a UC GIft Wrap module available from contrib on ubercart.org which I haven't looked at but that might be useful here.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Closed (won't fix)

I think this would probably be better implemented by a separate module which adds gift wrap as a line item, so it can be left untaxed ;)

rakugaki’s picture

rakugaki commented

did anyone ever find / develop a solution for this?

we have a product that is basically a donation (so tax free). however one of the levels of donation (attribute) includes a gift and therefore needs to be taxed.