I've found some E_NOTICE when I enabled the module.

Patch attached.

CommentFileSizeAuthor
#5 0001-Issue-528498-by-fgm-Fixed-E_STRICT-warning-on-missin.patch829 bytesfgm
#4 0001-Issue-528498-by-fgm-Fixed-E_STRICT-warning-on-missin.patch36.54 KBfgm
#1 og_user_roles.module.1.diff2.37 KBtamasd
og_user_roles.module.diff3.09 KBtamasd

Comments

tamasd’s picture

tamasd commented
StatusFileSize
new og_user_roles.module.1.diff2.37 KB

another one patch

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

1.x contains many many more PHP notices and warnings. An approach to fix them would be a waste of time, since 4.x is the future.

somebodysysop’s picture

somebodysysop commented
Status: Closed (won't fix) » Postponed (maintainer needs more info)

1.x contains many many more PHP notices and warnings.

This is true.

An approach to fix them would be a waste of time, since 4.x is the future.

This is partially true. I support the rise of OGUR 4.x. But, I do intend to support OGUR 1.x as long as needed before I can put those features into another module. And, I don't think of it as wasting my time.

The person who changed the status of these issues to "won't fix" was not authorized to do so: http://drupal.org/node/352139#comment-2352234

OGUR 6.x-1.x will continue to be maintained by me.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Version: 6.x-1.5 » 6.x-1.x-dev
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 0001-Issue-528498-by-fgm-Fixed-E_STRICT-warning-on-missin.patch36.54 KB

Previous fix missed one missing isset() which causes a Notice on (almost ?) every page.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 0001-Issue-528498-by-fgm-Fixed-E_STRICT-warning-on-missin.patch829 bytes

Oops wrong patch.