I am checking out the new (great looking and better flowing) Panels but stumbled upon some kind of strange misbehaviour. Panels shows the Rounded Corners ok, but completly lacks the background colour. See the attached pics (old shows the pane before upgrading and new after the upgrade; it also shows the only correct pane). I would guess that some of the massive changes in Panels/Ctools caused this but strangely _ONE_ block is displayed always correctly. It is a content pane created by views. Other panel panes don't work as expected.

A quick glance with firebug showes that the panes that are incorrectly displayed miss the div. node h2 title stuff. CSS is some kind of mystery to me so that I am sorry that I cannot provide more precise information.

I tried all kind of setting variations but to no avail. Therefore I am pretty sure either acquia_marina needs some pimping or Panels. If it is some kind of misconfiguration on my site I am sorry.

I absolutly love the fact that the panes could be displayed in block style (Title on green background) and hope this can be reintroduced.

Comments

dddave’s picture

Pffff,

found these entries in the watchdog. Might be helpful. ;)

Quite a bunch of these:

Location http://localhost/D6/de/admin/build/pages/nojs/operation/page-panelsaquia...
Referrer http://localhost/D6/de/admin/build/pages/nojs/operation/page-panelsaquia...
Message include() [function.include]: Failed opening './sites/all/modules/panels/plugins/styles/tnt_corners/acquia-marina-tnt-corners-box.tpl.php' for inclusion (include_path='.;C:\xampp\php\pear\') in C:\xampp\htdocs\D6\includes\theme.inc on line 1020.

And also two of those:

Location http://localhost/D6/de/admin/build/pages/nojs/operation/page-panelsaquia...
Referrer http://localhost/D6/de/admin/build/pages/nojs/operation/page-panelsaquia...
Message include(./sites/all/modules/panels/plugins/styles/tnt_corners/acquia-marina-tnt-corners-box.tpl.php) [function.include]: failed to open stream: No such file or directory in C:\xampp\htdocs\D6\includes\theme.inc on line 1020.

jwolf’s picture

Assigned: Unassigned » jwolf
Status: Active » Needs review
StatusFileSize
new1.17 KB
dddave’s picture

Thx. I am going to test it tomorrow.

dddave’s picture

Status: Needs review » Needs work
StatusFileSize
new1.17 KB

patch failed :(

Don't know the proper report procedure so I attached a copy of the .rej's content. Anything else I can do?

jwolf’s picture

Status: Needs work » Needs review

I tested the patch and it does work:

- Put the patch file in the plugins/styles/tnt_corners/ directory
- patch -p0 < tnt_corners_css.patch

Anyway, below is the full modified tnt_corners.css file:

.acquia_marina-corner-wrapper h2.pane-title {
  background-color: #94CE18;
  color: #fff;
  font-family: Myriad Pro,Myriad Web Pro Regular,Lucida Grande,Geneva,Trebuchet MS,sans-serif;
  font-size: 1.333em;
  font-weight: 600;
  margin: 0 0 10px;
  padding: 8px 8px 6px 46px;
  text-align: right;
  text-shadow: #545454 1px 1px;
  text-transform: uppercase;
  -moz-border-radius-topleft: 3px;
  -moz-border-radius-topright: 3px;
  -webkit-border-top-left-radius: 4px;
  -webkit-border-top-right-radius: 4px;
}

.acquia_marina-corner-wrapper .content {
  background: transparent url('block-gradient.png') no-repeat center bottom;
  border-bottom: 3px solid #F1F5F7;
  padding: 10px 10px 8px;
  -moz-border-radius-bottomleft: 6px;
  -moz-border-radius-bottomright: 6px;
  -webkit-border-bottom-left-radius: 4px;
  -webkit-border-bottom-right-radius: 4px; 
}

.acquia_marina-corner-corner {
  margin-top: -1px;                               /* use negative margin to overlap stacked blocks */
}

.acquia_marina-corner-topspace {
  margin-top: -14px;                                  /* removes unwanted space */
}

.acquia_marina-corner-bottomspace {
  margin-bottom: -10px;                               /* removes unwanted space */
}

.acquia_marina-corner-top-left, 
.acquia_marina-corner-top-right,
.acquia_marina-corner-bottom-left,
.acquia_marina-corner-bottom-right {
  background: transparent url('rounded-block.png') no-repeat;                         /* combined rounded corner image */
  font-size: 2px;                                 /* IE div correction */
  height: 11px;                                   /* height of an image corner */
}

.acquia_marina-corner-top-left,
.acquia_marina-corner-bottom-left { 
  margin-right: 11px;                             /* width of an image corner */
}

.acquia_marina-corner-top-right {                        /* anchor image in top right */
  background-position: 100% 0;
}

.acquia_marina-corner-top-right,
.acquia_marina-corner-bottom-right { 
  margin-left: 11px;                              /* width of an image corner */
  margin-top: -11px;                              /* height of an image corner */
}

.acquia_marina-corner-bottom-left  { 
  background-position: 0 -11px;                   /* negative height of an image corner */
}

.acquia_marina-corner-bottom-right { 
  background-position: 100% -11px;                /* negative height of an image corner */
}

.acquia_marina-corner-outside,
.acquia_marina-corner-inside {
  background: transparent url('rounded-block-inner.png') repeat-y right;
  padding-right: 8px;
}

.acquia_marina-corner-inside {
  background-position: left;
  padding: 0 0 0 8px;
}

.acquia_marina-corner-wrapper .pane-content {
  padding: 0 6px;
}

.acquia_marina-corner-wrapper div.node h2.title {
  border: none;
}
dddave’s picture

Hm... I retried and the patch failed again. Thanks for including the modified file. I swapped the files and it seems to be working well. All the beautiful green backgrounds are back and everything seems to behave fine. EXCEPT for this strange pane which was displayed correctly in the first place. This pane has lost the background. I am going to take a deeper testing tomorrow.

For now this patch looks good. Thanks!

dddave’s picture

Status: Needs review » Reviewed & tested by the community

Tested in FF3, IE8 and Safari and everything works fine and looks beautiful. Don't know if I count as "the community" but for me it works. Thx!

dddave’s picture

Status: Reviewed & tested by the community » Active

Sorry for the status change. Although the blocks are looking nice again something still is wrong. I keep getting bunches of errors like those above upon reordering stuff on panel pages.

Cannot make out if it is due to Panels or due to something of this theme (but I suspect it to be the theme as the the error message suggests it to my laymans eyes).

jwolf’s picture

I don't know why you're getting those errors. However I can verify that I am not seeing this problem.

I suspect that there is an issue with paths on your server. Specifically, I see in your posting above that:

Message include() [function.include]: Failed opening './sites/all/modules/panels/plugins/styles/tnt_corners/acquia-marina-tnt-corners-box.tpl.php'

/sites/all/modules/panels/plugins/styles/tnt_corners/acquia-marina-tnt-corners-box.tpl.php is not the correct location for that file. All acquia_marina panels files/styles MUST be located in the theme's plugins dir as they are in the 6.x-2.x-dev snapshot of the theme.

I also suspect that since you reported that the above patch, with instructions on how to apply the patch, does not work for you that you have a modified version of Acquia Marina 6.x-2.x-dev. You may want to try and downloading a fresh copy of the dev snapshot, clear data cache, and try again.

dddave’s picture

Well the errors above came indeed from a quite messy testinstall on my laptop yet I am also getting those kinds of errors from another install were I am quite confident to not have messed up things. I will take a look into it over the weekend because I really don't understand how this path comes up. It is working nicely just these messages are disturbing.

As far as patching is concerned, I normally don't have problems with it. So this indeed points to some problems on my sites.

dddave’s picture

I think I found the (pretty obvious) solution. I tested and tested and finally noticed that the errors seemed only to occur when I used panels "update and preview" option instead of the ordinary "update" option. So my theory quickly was, that something breaks during the preview process. Considering that I don't use Acquia_Marina on my admin pages and instead make use of Garland as admin theme points the searchlight pretty well. I switched to Acquia_Marina also on the admin pages and the problem went away.

I don't know if this problem is more one of the preview process of panels and if it can be solved within this theme but I am glad that I finally could make some sense of it.

jwolf’s picture

Status: Active » Postponed

@dddave - thanks for the great troubleshooting feedback; very helpful.

We're in the process of porting Marina over to our new theme system, Fusion.

I'm marking this as postponed because the current 2.x branch code will be replaced with Fusion and Panels 3 is still evolving.

jwolf’s picture

Title: Panels rc1 chokes on Acquia Marina Rounded Corners Style » Panels 3 and Acquia Marina Rounded Corners Style
mariagwyn’s picture

I have downloaded the most recent dev version, which does have the styles in the appropriate theme folder. But I still get this error:
warning: include(./sites/all/modules/panels/plugins/styles/tnt_corners/acquia-marina-tnt-corners-box.tpl.php) [function.include]: failed to open stream: No such file or directory in /Users/.../Sites/acquia-dpl/acquia-drupal/includes/theme.inc on line 1020.

dddave’s picture

Are you using a admin theme so that all your panel edit work happens with a non aquia_marina theme? If that is the case you have the same situation as descibed above.

andraeray’s picture

Are the pictures still there in the tnt corners patch? I don't see my user menu having the star, while using the panels 3 display.

ayalon’s picture

Status: Postponed » Needs work

I had the same problem with my own styles. It cannot work becaus of this line:

'path' => panels_get_path('plugins/styles/tnt_corners'),


function acquia_marina_tnt_corners_panels_styles() {
  return array(
    'tnt_corners' => array(
      'title' => t('Acquia Marina Rounded Corners'),
      'description' => t('Presents the panes or panels with a themed rounded corner box around them'),
      'render panel' => 'acquia_marina_tnt_corners_style_render_panel',
      'render pane' => 'acquia_marina_tnt_corners_style_render_pane',
      'settings form' => 'acquia_marina_tnt_corners_style_settings_form',
      'hook theme' => array(
        'acquia_marina_tnt_corners_box' => array(
          'arguments' => array('content' => NULL),
          'path' => panels_get_path('plugins/styles/tnt_corners'),
          'template' => 'acquia-marina-tnt-corners-box',
        ),
      ),
    ),
  );
}

This will get the path relative to the panels module folder and will fail because the styles are in the templates folder.

I wrote a simple workaround:

1#: Add the following function to you theme template.php

function mytheme_get_path($file, $base_path = FALSE, $theme = 'mytheme') {
$output = $base_path ? base_path() : '';
return $output . drupal_get_path('theme', $theme) . '/' . $file;
}

2#. Change the line to:
'path' => mytheme_get_path('plugins/styles/tnt_corners');

jwolf’s picture

Status: Needs work » Needs review
jwolf’s picture

Category: bug » support
Status: Needs review » Postponed (maintainer needs more info)

I've done a fresh install of Drupal. Checkout the latest version of panels 3 (6.x-3.2) and ctools (6.x-1.2). I created several different panel pages, mini panels from scratch and I am not seeing these error messages.

Any chance you are using the dev snapshot of ctools?

dddave’s picture

Version: 6.x-2.x-dev » 6.x-3.0-alpha1
Category: support » bug
Status: Postponed (maintainer needs more info) » Active

I am retagging and reactivating this issue because it perfectly fits my description in the OP. Basically rounded corners in Panels aren't working at the moment (Skinr 1.5, Ctools 1.3, Panels 3.3, Fusion 1.0 rc1)
and the skinr settings for Acquia Marina - Block Title Styles ( such as "Blue rounded title background with white text" or
"Green rounded title background with white text") are missing.

Therefore Panels is pretty lame at the moment with this theme. When I put some other (none views) blocks into the pane I get the Block Title Style options however they aren't applied.

Please, please reintroduce these great settings for panes.

dddave’s picture

Title: Panels 3 and Acquia Marina Rounded Corners Style » Panels 3 and Acquia Marina not really working (Rounded Corners + Block Title Style)

btw: I noticed the bunches of Panels+Skinr issues but I am not sure if the problems described above are purely skinr issues. AM3 seems to lack on this front.

dddave’s picture

For the record: Tested with Fusion core and the result is the same. Important for me is that Acquia Marina Block Style Settings makes a comeback soon. ;)

dddave’s picture

Are the block title style settings to be reintroduced in the next release (btw. is there an ETA?)?

jeremycaldwell’s picture

Assigned: jwolf » jeremycaldwell
StatusFileSize
new115.64 KB

I worked on this issue quite a bit this morning and have all the Skinr styles supplied in the theme working within Panels now. Attached is screenshot of it in action :)

We need to review these changes and test them locally a bit more before we release them, but it's on the way real soon.

dddave’s picture

Great, great news.

You guys and gals really rock!

jeremycaldwell’s picture

StatusFileSize
new66.21 KB

Also I have the edit options overlay working and not being hidden by the other regions. Attached is a screenshot. Hopefully we'll be able to test these real quick and get them in the next update of the theme.

dddave’s picture

Yes, that would be a nice fix for this usability problem.

Looking forward to it.

jeremycaldwell’s picture

Status: Active » Fixed

Fixed in the Alpha 2 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.