I'm testing this module, however I'm a bit confused about the pathauto setting with the checkbox:
"Keep track of pathauto checkbox state?"

It doesn't seem to do anything. (module weight is ok)

I would expect it to fix this pathauto issue:
http://drupal.org/node/369840

Could anyone shine some light on this?

Comments

Kristen Pol’s picture

Yes, it should keep track of whether you have unchecked the checkbox for a particular node so that when you go back to edit that node later, it will be unchecked. It was working for me when I tested previously but perhaps that was with an older version of pathauto. What version are you using?

Thanks,
Kristen

askibinski’s picture

I just double checked, doesn't seem to be a user permission issue. Even with root user the checkbox is re-checked when I uncheck it, enter a custom url, save it, and re-edit.

drupal 6.13
pathauto 6.x-1.1

Kristen Pol’s picture

It was a bug. I fixed and it will be in the dev snapshot as soon as the drupal cvs cron runs later today. Once it's there, if you can test and confirm it's working, then I can tag a new beta release.

Thanks!!!
Kristen

Dave Reid’s picture

Or you could encourage people to actually review the patch in pathauto so this is fixed for all users, not just the ones using seo friend. #369840: If a user changes the automatic path, try to remember that in the future

Kristen Pol’s picture

Thanks for pointing me to that. When I had looked into it in the past, the maintainer said something like "it's not a bug, and I'm not going to change it". I took that to mean that a change in functionality was not desired and a patch wouldn't be accepted. I hadn't realized that people decided to do a patch anyway... that's great. I'll try to dig into this sometime this week. It certainly would be much nicer to have it in pathauto than in my module!

Thanks,
Kristen

Dave Reid’s picture

I think what had happened is that the maintainers were frustrated that everyone wanted a fix, but no one was willing to code it, so it got to the point of "ok since no one is going to help fix it, it's going to stay that way." The current status is I'm determined to get the fix in and I know both maintainers want this to be fixed, but it just takes some people to test out the patch and review it. :)

Kristen Pol’s picture

Thanks for the history. I'm happy to test it out and whatever else is needed :) This has been an annoying issue for so long I'm very happy to hear that it's finally going to be resolved!!!!!!!!!!!!!!

:)kristen

Kristen Pol’s picture

Status: Active » Closed (fixed)

I read through the various threads and there appears to be proper patches (1.x & 2.x) that work but they won't be applied until the maintainers raise some money for it:

http://freso.chipin.com/fixing-issue-180440-dont-automatically-replace-m...

Seems kind of strange to me since it really feels like a bug to me and not a feature, but if that's what it takes, I guess everyone should donate a few dollars to see it get into pathauto where it belongs. Otherwise, feel free to use seo_friend beta3 and it should be working.

One note is that the patch contributed for pathauto uses some logic to determine whether or not to check/uncheck the checkbox, but my code doesn't try to be so clever. It simply keeps track of whether or not you've checked/unchecked it yourself upon saving the node and uses that data later.

:)Kristen

Dave Reid’s picture

No, don't donate to that. :) I think that the donation pages were created along with the logic of "ok since no one wants to help contribute code, you can donate to pay the maintainer's time to fix it" since it isn't exactly the easiest fix. Anyway, those donation pages have ended. All that's needed is people to review and RTBC the pathauto patch.

Kristen Pol’s picture

Ok, guess I got confused... I found this thread: http://drupal.org/node/180440 and at the bottom it had the chipin.

Your link above is more recent. So, I guess the steps are to download both patches and test with 1.x & 2.x and then go to:

http://drupal.org/node/369840

and say you have tested and it's good to go. Yes?

It's always hard to track down the right patches because they are buried in the thread. I was there was an easier way to locate them in an issue thread... perhaps that could be a feature improvement to the project module.

Kristen