Like sdboyer initially propose, I made autoload integration, and I think it __really make it clear__ :-D.

Take a look to my autoload branches on versioncontrol and versioncontrol_git

So, what do you think about it?

Like you see, I'm really pro it!

CommentFileSizeAuthor
#3 0001-autoload-integration-aka-avoid-manual-requires.patch15.55 KBmarvil07

Comments

marvil07’s picture

marvil07 commented

I mean http://drupal.org/project/autoload , just in case

marvil07’s picture

marvil07 commented
Status: Needs review » Active

jpetso is ok with this integration like we chat some minutes ago, but after dww comments I would prefer to maintain those mentioned branches some more time

marvil07’s picture

marvil07 commented
Version: 6.x-1.0-rc2 » 6.x-2.x-dev
Assigned: marvil07 » Unassigned
StatusFileSize
new 0001-autoload-integration-aka-avoid-manual-requires.patch15.55 KB

more feedback is welcome.

since we have decided to re-work queries with dbtng(#528966: dbtng integration) depending on that module, maybe it's also a good idea to depend on autoload, I really think it makes the code cleaner

Attaching the patch here(take a look at it, _lots of_ removes :-p)

marvil07’s picture

marvil07 commented
Status: Active » Fixed

This was committed by Sam some weeks ago, but since he rewrite it instead of looking at the queue :-p, he miss some little things, but he also add some others, so great.

I'm closing this issue after committing #800544: make tests work again since autoload integration, which update the missing stuff on tests.

sdboyer’s picture

sdboyer commented

Err. Whoops. Thanks :)

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Fixed » Needs work

This is slightly broken. If you're going to do autoloading, each class needs to be in a separate file to work reliably. I fixed #832660: Error on install by making the following changes (can't make a patch right now...sorry):

-Remove line 147-167 in versioncontrol.module
-Add

// Include classes.inc so the autoloader doesn't get confused
require_once drupal_get_path('module', 'versioncontrol') . '/includes/classes.inc';

at around line 117

marvil07’s picture

marvil07 commented
Status: Needs work » Fixed

mmm.. this was worked and committed on several commits IIRC before entities patch.

The point is that 2.x depend on autoload some time ago.

Status: Fixed » Closed (fixed)
Issue tags: -integration

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +integration

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.