Posted by marvil07 on July 23, 2009 at 6:30pm
| Project: | Version Control API |
| Version: | 6.x-2.x-dev |
| Component: | API module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | integration |
Issue Summary
Like sdboyer initially propose, I made autoload integration, and I think it __really make it clear__ :-D.
Take a look to my autoload branches on versioncontrol and versioncontrol_git
So, what do you think about it?
Like you see, I'm really pro it!
Comments
#1
I mean http://drupal.org/project/autoload , just in case
#2
jpetso is ok with this integration like we chat some minutes ago, but after dww comments I would prefer to maintain those mentioned branches some more time
#3
more feedback is welcome.
since we have decided to re-work queries with dbtng(#528966: dbtng integration) depending on that module, maybe it's also a good idea to depend on autoload, I really think it makes the code cleaner
Attaching the patch here(take a look at it, _lots of_ removes :-p)
#4
This was committed by Sam some weeks ago, but since he rewrite it instead of looking at the queue :-p, he miss some little things, but he also add some others, so great.
I'm closing this issue after committing #800544: make tests work again since autoload integration, which update the missing stuff on tests.
#5
Err. Whoops. Thanks :)
#6
This is slightly broken. If you're going to do autoloading, each class needs to be in a separate file to work reliably. I fixed #832660: Error on install by making the following changes (can't make a patch right now...sorry):
-Remove line 147-167 in versioncontrol.module
-Add
// Include classes.inc so the autoloader doesn't get confusedrequire_once drupal_get_path('module', 'versioncontrol') . '/includes/classes.inc';
at around line 117
#7
mmm.. this was worked and committed on several commits IIRC before entities patch.
The point is that 2.x depend on autoload some time ago.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.