disable can still fail disabling damaged sites
| Project: | Provision |
| Version: | 6.x-0.4-alpha1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | anarcat |
| Status: | closed |
We need to be able to deal better with damaged sites. Here, there was a permissions screwup on drushrc.php, and then verify actually destroyed the information in settings.php and couldn't recreate the drushrc.php properly. So the situation was that the authentication information was lost, both in drushrc and settings.php. Site unrecoverable. I should be able to disable then delete it from the system.
First blocker is this in platform/disable.provision.inc, drush_provision_drupal_provision_disable_validate() does a site bootstrap which fails and pops up an error. First bad idea.
Second blocker is the backup validation which does exactly the same thing.
I propose to remove the validation from disable (since it's done in backup and is not required by validate per se) and make the bootstrap fail in backup only if force is off.
Patch attached.
| Attachment | Size |
|---|---|
| strong_disable.patch | 4.82 KB |
#1
Getting rusty with patches, reroll without extra changes.
#2
Committed to CVS.
#3
Automatically closed -- issue fixed for 2 weeks with no activity.
#4
This is still relevant. If a site disappeared from the backend, it will not be possible to disable/delete it from the frontend. The problem is in the backup bootstrap:\
Including /var/hostmaster/.drush/provision/db_server/backup.provision.incCould not find a Drupal settings.php file at ./sites/default/settings.php.
Undefined variable: count
An error occurred at function : drush_provision_drupal_provision_backup_validate
An error occurred at function : drush_provision_drupal_pre_provision_disable
This is probably related to:
function drush_provision_drupal_provision_backup_validate($url = NULL, $backup_file = NULL) {drush_bootstrap(DRUSH_BOOTSTRAP_DRUPAL_SITE);
...
#5
So I have a rather crude hack for this, not sure it's really nice to do this, would like to get feedback from adrian before committing:
http://git.koumbit.net/?p=drupal/modules/provision/.git;a=commitdiff;h=3...
#6
this looks sane , feel free to commit.
#7
Pushed to CVS.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.